-
Notifications
You must be signed in to change notification settings - Fork 62
DOCSP-41049 schemaHint option #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-41049 schemaHint option #205
Conversation
✅ Deploy Preview for docs-spark-connector ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! just left a tiny comment but overall good work
source/batch-mode/batch-read.txt
Outdated
format by using the Spark shell. The example specifies a ``string`` field named | ||
``"value"`` and an ``integer`` field named ``"count"``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: in this context, I am not sure it's necessary to monospace string and integer. What about:
format by using the Spark shell. The example specifies a ``string`` field named | |
``"value"`` and an ``integer`` field named ``"count"``. | |
format by using the Spark shell. The example specifies a string-valued field named | |
``"value"`` and an integer-valued field named ``"count"``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
(cherry picked from commit 77ace85)
(cherry picked from commit 77ace85) Co-authored-by: Jordan Smith <[email protected]>
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-41049
Staging - https://preview-mongodbjordansmith721.gatsbyjs.io/spark-connector/DOCSP-41049-schemaHints/batch-mode/batch-read/#specify-known-fields-with-schema-hints
Self-Review Checklist