Skip to content

DOCSP-41049 schemaHint option #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jordan-smith721
Copy link
Contributor

@jordan-smith721 jordan-smith721 commented Sep 3, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-41049
Staging - https://preview-mongodbjordansmith721.gatsbyjs.io/spark-connector/DOCSP-41049-schemaHints/batch-mode/batch-read/#specify-known-fields-with-schema-hints

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for docs-spark-connector ready!

Name Link
🔨 Latest commit 9e4af33
🔍 Latest deploy log https://app.netlify.com/sites/docs-spark-connector/deploys/66d888cb764b130008011455
😎 Deploy Preview https://deploy-preview-205--docs-spark-connector.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jordan-smith721 jordan-smith721 changed the title DOCSP-41049 schameHint option DOCSP-41049 schemaHint option Sep 3, 2024
Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just left a tiny comment but overall good work

Comment on lines 91 to 92
format by using the Spark shell. The example specifies a ``string`` field named
``"value"`` and an ``integer`` field named ``"count"``.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: in this context, I am not sure it's necessary to monospace string and integer. What about:

Suggested change
format by using the Spark shell. The example specifies a ``string`` field named
``"value"`` and an ``integer`` field named ``"count"``.
format by using the Spark shell. The example specifies a string-valued field named
``"value"`` and an integer-valued field named ``"count"``.

Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jordan-smith721 jordan-smith721 merged commit 77ace85 into mongodb:master Sep 9, 2024
7 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 9, 2024
jordan-smith721 added a commit that referenced this pull request Sep 9, 2024
(cherry picked from commit 77ace85)

Co-authored-by: Jordan Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants