PHPLARA-257 Replay query macros when eager loading MorphTo relations

[GromNaN]

PHPLARA-257

Eager loading a morphTo() relationship with withTrashed() returned null instead of the soft-deleted related model. Lazy loading was not affected.

class Photo extends Model
{
    public function hasImage(): MorphTo
    {
        return $this->morphTo()->withTrashed();
    }
}

Photo::with('hasImage')->get(); // hasImage was null when the related model is soft-deleted

MongoDB\Laravel\Relations\MorphTo::getResultsByType() was a stripped-down copy of the Laravel implementation, unchanged since 2015. It built the query with a plain $instance->newQuery(), which drops replayMacros(). That call is what makes withTrashed() work: MorphTo cannot apply it to the parent query because the macro only exists on the related model, so it buffers the call and replays it once per morph type. Without the replay the SoftDeletingScope is never removed.

The same omission silently disabled mergeConstraintsFrom(), with() and withCount(), which made morphWith(), morphWithCount() and constrain() no-ops on MongoDB.

The two reasons the override existed no longer apply:

• DocumentModel::qualifyColumn() returns the column unchanged, so the parent's $instance->qualifyColumn($ownerKey) is already correct for MongoDB.
• whereInMethod() is separately overridden to return whereIn instead of whereIntegerInRaw.

So the override is removed and the Laravel implementation is inherited. Tests cover withTrashed(), constrain() and morphWith(), all three failing on the previous code.

Fixes #3454
Fixes #1361

[Copilot]

Pull request overview

This PR fixes eager loading of MorphTo relations when query macros (notably withTrashed()) must be replayed per morph type, aligning MongoDB behavior with upstream Laravel and restoring buffered macro/constraint behavior during eager loading.

Changes:

• Removes the MongoDB-specific MorphTo::getResultsByType() override so the package inherits Laravel’s macro-replay implementation.
• Adds a regression test covering lazy vs eager loading for morphTo()->withTrashed() against a soft-deleted related model.
• Extends the test Photo model with a hasImageWithTrashed() relation for the new test.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
tests/RelationsTest.php	Adds a regression test for eager-loaded morphTo()->withTrashed() returning soft-deleted related models.
tests/Models/Photo.php	Adds a hasImageWithTrashed() morph-to relation used by the new test.
src/Relations/MorphTo.php	Removes the custom getResultsByType() override to rely on Laravel’s implementation (enabling macro replay/constraint merging).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.