test: verify transactionLevel() reflects the active transaction insid… - #3572
Open
zigzagdev wants to merge 1 commit into
Open
test: verify transactionLevel() reflects the active transaction insid…#3572zigzagdev wants to merge 1 commit into
transactionLevel() reflects the active transaction insid…#3572zigzagdev wants to merge 1 commit into
Conversation
…e transaction() closure PHPLARA-29 / mongodbGH-2851 reported that Connection::transactionLevel() returned 0 from inside the closure passed to transaction(), because the old implementation never set $this->transactions before invoking the callback. transaction() now calls handleInitialTransactionState() (which sets $this->transactions = 1) before invoking the callback, so this is already fixed. Add a regression test to lock in the behavior and close out the ticket.
zigzagdev
changed the title
transactionLevel() reflects the active transaction insid…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PHPLARA-29 / GH-2851
Reported that
Connection::transactionLevel()returned0from inside the closure passed totransaction(), because the old implementation never set$this->transactionsbefore invoking the callback.And
transaction()now callshandleInitialTransactionState()(which sets$this->transactions = 1) before invoking the callback, so this is already fixed as a side effect of later work on transaction event handling.No production code change is needed.
What I have done
testTransactionLevelInsideClosure()totests/TransactionTest.phpto lock in the current (correct) behaviour and close out the ticket.Checklist