PHPLARA-262 Support serializable classes allowlist in MongoStore cache - #3573
Open
paulinevos wants to merge 1 commit into
Open
PHPLARA-262 Support serializable classes allowlist in MongoStore cache#3573paulinevos wants to merge 1 commit into
paulinevos wants to merge 1 commit into
Conversation
Laravel added an opt-in allowlist of classes that cache stores may instantiate while unserializing, configured with cache.serializable_classes. MongoStore was the last store not honouring it, so applications hardening their cache had a gap they could not close. The default stays unrestricted, so existing behaviour is unchanged.
There was a problem hiding this comment.
Pull request overview
Adds support for Laravel’s cache.serializable_classes configuration to the MongoDB cache store so applications can restrict which classes may be instantiated during cache unserialization (default remains unrestricted for backwards compatibility).
Changes:
- Pass
cache.serializable_classesfrom the service provider intoMongoStore. - Apply PHP’s
unserialize(..., ['allowed_classes' => ...])option inMongoStorewhen configured. - Add test coverage for default/unrestricted behavior, deny-all behavior, and allowlist behavior; update the cache configuration reference docs.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/Cache/MongoCacheStoreTest.php | Adds tests validating default behavior and the new allowlist/denylist unserialization behavior. |
| src/MongoDBServiceProvider.php | Wires cache.serializable_classes config into the MongoStore constructor. |
| src/Cache/MongoStore.php | Stores the allowlist setting and uses it when unserializing cached values. |
| resources/boost/skills/laravel-mongodb/references/cache-sessions.md | Documents the serializable_classes cache configuration option. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
GromNaN
reviewed
Aug 28, 2026
GromNaN
left a comment
GromNaN
left a comment
Member
There was a problem hiding this comment.
The PR will have to target the current minor (5.9)
|
|
||
| // Optional: restrict which classes may be unserialized from the cache. | ||
| // null (default) allows all, false allows none, or list allowed classes. | ||
| 'serializable_classes' => null, |
Member
There was a problem hiding this comment.
Maybe set to false, to be secure by default when using this feature.
Suggested change
| 'serializable_classes' => null, | |
| 'serializable_classes' => false, |
| return $repository; | ||
| } | ||
|
|
||
| private function getStoreAllowing(array|bool|null $serializableClasses): Repository |
Member
There was a problem hiding this comment.
null is not used.
Suggested change
| private function getStoreAllowing(array|bool|null $serializableClasses): Repository | |
| private function getStoreAllowing(array|bool $serializableClasses): Repository |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Laravel added an opt-in allowlist of classes that cache stores may instantiate while unserializing, configured with cache.serializable_classes. MongoStore was the last store not honouring it, so applications hardening their cache had a gap they could not close.
The default stays unrestricted, so existing behaviour is unchanged.
Checklist