Skip to content

fix(toast): make toast icon accessible to screen readers #3057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 19, 2025
Merged

fix(toast): make toast icon accessible to screen readers #3057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d6b4679
changes
bruugey Aug 19, 2025
3952457
Update InternalToast.tsx
bruugey Aug 28, 2025
af8df03
Merge branch 'main' into brooke/toast-a11y
bruugey Aug 28, 2025
1f18eb0
fix test suite to match
bruugey Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/warm-groups-fly.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@leafygreen-ui/toast': patch
---

Updates the Toast Icon to be labeled for screen readers
10 changes: 5 additions & 5 deletions packages/toast/src/InternalToast/InternalToast.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,11 @@ describe('packages/toast/internal-toast', () => {

describe('the correct icon is rendered', () => {
const expectedVariantIcons: Record<Variant, string> = {
[Variant.Success]: 'Checkmark With Circle Icon',
[Variant.Note]: 'Info With Circle Icon',
[Variant.Warning]: 'Warning Icon',
[Variant.Important]: 'Important With Circle Icon',
[Variant.Progress]: 'Refresh Icon',
[Variant.Success]: 'success notification',
[Variant.Note]: 'note notification',
[Variant.Warning]: 'warning notification',
[Variant.Important]: 'important notification',
[Variant.Progress]: 'progress notification',
};

test.each(Object.values(Variant) as Array<Variant>)(
Expand Down
3 changes: 2 additions & 1 deletion packages/toast/src/InternalToast/InternalToast.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,8 @@ export const InternalToast = React.forwardRef<
})}
>
<VariantIcon
aria-hidden
role="img"
aria-label={`${variant} notification`}
className={cx(baseIconStyle, iconThemeStyle[theme])}
size={32}
/>
Expand Down
Loading