chore(code): remove deprecated prop warnings and storybook references #3171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephl3
requested review from
Copilot and
TheSonOfThomp
and removed request for
a team
🦋 Changeset detectedLatest commit: 4fd7e70 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR removes deprecated prop warning logic and Storybook references from the @leafygreen-ui/code component. The deprecated props (copyable, showCustomActionButtons, languageOptions, customActionButtons, chromeTitle, onChange) were already removed in v18, and this cleanup removes the remaining runtime warning code and Storybook control references.
Key changes:
- Removes deprecated prop warning checks from the Code component
- Removes deprecated prop references from Storybook configuration
- Adds changeset documenting the cleanup
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/code/src/Code/Code.tsx | Removes deprecated prop warning logic that checked for props removed in v18 |
| packages/code/src/Code.stories.tsx | Removes copyable control references from Storybook configuration |
| .changeset/nasty-planets-tap.md | Documents the removal of deprecated prop mentions as a patch change |
|
Size Change: -291 B (-0.02%) Total Size: 1.59 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
This PR cleans up the
@leafygreen-ui/codecomponent by removing deprecated prop warning checks and Storybook references. These props (copyable, showCustomActionButtons, languageOptions, customActionButtons, chromeTitle, onChange) were already removed in v18, and this change removes the runtime warning code and any remaining references in Storybook configuration.🎟️ Jira ticket: N/A
✅ Checklist
pnpm changesetand documented my changes🧪 How to test changes
copyablecontrol no longer appears in the Storybook controls panel