Skip to content

fix(message): remove standalone MessagePromotion export #3180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −4
Open

fix(message): remove standalone MessagePromotion export #3180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f12054b
fix(message): remove MessagePromotion export
stephl3 Oct 1, 2025
b49050c
chore(message): changeset
stephl3 Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/rude-rockets-crash.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@lg-chat/message': patch
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this only a patch?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shaneeza it was inadvertently exported in the previous release. I was treating this as a fix and going to deprecate the version that initially exported it since it doesn't yet have usage. Do you think that would be fine or does this need to be a major version?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I'm not sure. I would bring it up with the team.

---

Remove `MessagePromotion` export
5 changes: 1 addition & 4 deletions chat/message/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,4 @@ export {
MessageLinks,
type MessageLinksProps,
} from './MessageLinks';
export {
MessagePromotion,
type MessagePromotionProps,
} from './MessagePromotion';
export { type MessagePromotionProps } from './MessagePromotion';
Loading