Fix default style (svg width/height) & css prop on promotions #3185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2df2eee The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +70 B (0%) Total Size: 1.6 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
Fixes default style on Message.Promotion component. The style
box-sizing: border-boxwas missing, causing the promotion badge size to be wrong when implemented on the MongoDB Assistant. On Storybook,border-boxis set by default on all elements under the Story root element, so this issue was not caught previously.I've also made it possible for users to pass in custom styles on the promotions with
className, as it could be a helpful workaround for users if any similar issues arise.I also updated the stories:
classNameprop, passing differentbox-sizingon the promotion container.✅ Checklist
For bug fixes, new features & breaking changes
HTMLElementProps<'div'>is already documented in the readme]pnpm changesetand documented my changes🧪 How to test changes