[LG-5830] feat(collection-toolbar): Collection Toolbar component#3419
[LG-5830] feat(collection-toolbar): Collection Toolbar component#3419adamrasheed merged 18 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: a7a4095 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: -41 B (0%) Total Size: 1.85 MB
ℹ️ View Unchanged
|
20b8bfe to
2803b0a
Compare
…nt (#3420) * [LG-844] feat(collection-toolbar): Title component * updated lintin * updated tests, linitng cleanup * feedback updates * fixed type exports * updated collectionToolbar ref, updated added types docs * added context provider * fixed storybook darkmode, updated defaul theading element * reverted heading * added refs
2803b0a to
d8e1163
Compare
…th Button, Menu, MenuItem, and Pagination (#3432) * [LG-844] feat(collection-toolbar): Title component * updated lintin * updated tests, linitng cleanup * feedback updates * added context provider * fixed storybook darkmode, updated defaul theading element * [LG-5840] feat(collection-toolbar): Collection toolbar actions + Button * updates * adding pagination * added menu, menuitem, pagination, added unit tests * rm vscode settings * linting fix, updated tests * updated test * cleanup * moved to named exports, made toggleButton optional * updated provider logic, added unit test * updated for r17 * test cleanup * tests cleanup * updated title test, updated button types * updated menuProps * cleanup
* [LG-5838] feat(collection-toolbar): SearchInput Component * revert vscode settings * linting * cleanup * updated title styles * updated styles, cleanup * cleaned up prop types * added ally package * style cleanup, rc17 fix * linting
* [LG-5838] feat(collection-toolbar): SearchInput Component * revert vscode settings * linting * cleanup * updated title styles * updated styles, cleanup * [LG-5841] feat(collection-toolbar): Filters and Subcomponents * [LG-5841] feat(collection-toolbar): Filters and Subcomponents * cleanup * added root styles, added segmentcontrol, select, and option * linting * added filter widths, cleanup * cleaned up stories, added unit test, styling updates * updated test, cleanedup label props * updated styling colocation, cleaned up exports, organized types * cleaned up searchinput types, udpated exports * cleanup * updated a11y types, fixed exports * cleaned up searchInput * fix tests * r17 fix, cleanup * Added comboboxoption, added missing exports, lgid cleanup * select cleanup * ref cleanup * exported ComboBoxOptionProps * updated filters styles, revert select * updated types, rm extra className, rename SelectOption * r17 fix * Added changeset
* [LG-5838] feat(collection-toolbar): SearchInput Component * revert vscode settings * linting * cleanup * updated title styles * updated styles, cleanup * [LG-5841] feat(collection-toolbar): Filters and Subcomponents * [LG-5841] feat(collection-toolbar): Filters and Subcomponents * cleanup * added root styles, added segmentcontrol, select, and option * linting * added filter widths, cleanup * cleaned up stories, added unit test, styling updates * updated test, cleanedup label props * updated styling colocation, cleaned up exports, organized types * cleaned up searchinput types, udpated exports * cleanup * updated a11y types, fixed exports * cleaned up searchInput * fix tests * r17 fix, cleanup * Added comboboxoption, added missing exports, lgid cleanup * select cleanup * ref cleanup * exported ComboBoxOptionProps * updated filters styles, revert select * updated types, rm extra className, rename SelectOption * r17 fix * [LG-5937] feat(collection-toolbar): Refactor Compound Components * added changeset * rm changeset * cleanup * fixed tests, update selectOption displayName * exported menuItemClassName, added children validation * renamed pt1 * renamed ComboboxOption pt2 * rename pt3 * rename pt4 * cleanup * cleanup * more cleanup
…ling (#3497) * [LG-5845] feat(collection-toolbar): Variant Styling * added terst * tests cleanup * updated render logic, a11y improvements, animation styling improvements * updated stories, updated mobile styles * updated stories formatting * updated styles
younlee-creator
left a comment
There was a problem hiding this comment.
Responsive behavior checked
tsck
left a comment
There was a problem hiding this comment.
Gave a quick scan and other than the version question, nothing looks out of place. Just want to verify though - this is just merging this integration branch into main, correct? So all of this code should have been previously reviewed?
|
Coverage after merging ar/LG-5830-collection-toolbar into main will be
Coverage Report for Changed Files
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
@tsck correct, all previous PRs into this feature branch were reviewed. I believe the only updates made in this branch itself were some minor responsiveness tweaks |
|
@adamrasheed Awesome, approved! |
✍️ Proposed changes
This is the launching PR for the Collection Toolbar feature. This branch serves as the integration point for all Collection Toolbar related work. Additional PRs will be pointed to this branch and merged here incrementally.
This PR will only be merged to main when the feature is ready for launch.
Changes in this PR:
@leafygreen-ui/collection-toolbarpackage: Initial scaffolding for the Collection Toolbar component with base structure, types, styles, stories, and testing utilities🎟️ Jira ticket: LG-5830
✅ Checklist
🧪 How to test changes
pnpm storybookComponents/CollectionToolbar