CDRIVER-4722 remove cursor support for legacy opcodes #2112
+75
−1,327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorsmacd
changed the title
connorsmacd
changed the title
kevinAlbs
reviewed
Sep 12, 2025
| @@ -569,8 +569,6 @@ set (MONGOC_SOURCES | |||
| ${PROJECT_SOURCE_DIR}/src/mongoc/mongoc-cursor-cmd-deprecated.c | |||
| ${PROJECT_SOURCE_DIR}/src/mongoc/mongoc-cursor-find.c | |||
| ${PROJECT_SOURCE_DIR}/src/mongoc/mongoc-cursor-find-cmd.c | |||
| ${PROJECT_SOURCE_DIR}/src/mongoc/mongoc-cursor-find-opquery.c | |||
There was a problem hiding this comment.
FYI: before closing CDRIVER-4722, set PHP Team Attention Needed: Needed. I expect the file removal will require an update to the PHP driver build listing of source files: https://github.com/mongodb/mongo-php-driver/blob/5bf907601604618556de9698ed26a4b5a4ad54b4/config.m4#L363
kevinAlbs
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: https://jira.mongodb.org/browse/CDRIVER-4722
Motivation
Now that our minimum wire version is 4.2, we can use exclusively use
OP_MSGfor cursors.Changes