CDRIVER-6045 Support TLS v1.3 in Secure Channel #2118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9c62ea9.
kevinAlbs
reviewed
Sep 29, 2025
kevinAlbs
approved these changes
Oct 1, 2025
src/libmongoc/src/mongoc/mongoc-stream-tls-secure-channel-private.h
Outdated
Show resolved
Hide resolved
|
|
||
| DWORD enabled_protocols = SP_PROT_TLS1_1_CLIENT | SP_PROT_TLS1_2_CLIENT; | ||
|
|
||
| /* TLS 1.3 is supported on Windows Server 2022 and newer. |
There was a problem hiding this comment.
Evergreen tasks do not appear to test TLS 1.3 against cloud-dev (even when enabled). I expect that is why when TLS 1.3 was enabled without renegotiation, Evergreen still passed.
The authentication-tests-winssl task that tests connecting to cloud-dev here
Suggest (either here or in later PR) adding an Evergreen task to test cloud-dev with TLS 1.3. I expect that would mean:
- Copy the VS 2017 variant to test VS 2022. Limit it to testing
".authentication-tests .winssl". - Regenerate the Evergreen config (see docs)
mdb-ad
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable TLS 1.3 in the C driver when using Windows Secure Channel as the TLS implementation (default on Windows).
Changes
Used libcurl as a reference.
(In a second PR)
Secure Channel with TLS 1.3 may use the renegotiate status for internal use; instructions on how to handle this are given in Windows documentation.