-
Notifications
You must be signed in to change notification settings - Fork 1.3k
CSHARP-4040: Use AppContext switch to disable CSHARP-4040 validation #1825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1337,6 +1337,11 @@ internal IDiscriminatorConvention GetDiscriminatorConvention() | |
|
|
||
| void EnsureNoMemberMapConflicts(string elementName) | ||
| { | ||
| if (AppContext.TryGetSwitch("DisableCSharp4040Validation", out bool disableCSharp4040Validation) && disableCSharp4040Validation) | ||
|
||
| { | ||
| return; | ||
| } | ||
|
|
||
| var conflictingMemberMap = _allMemberMaps.FirstOrDefault(memberMap => memberMap.ElementName == elementName); | ||
|
|
||
| if (conflictingMemberMap != null) | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,183 @@ | ||
| /* Copyright 2010-present MongoDB Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using MongoDB.Driver.TestHelpers; | ||
| using FluentAssertions; | ||
| using MongoDB.Bson.Serialization; | ||
| using MongoDB.Bson.Serialization.Conventions; | ||
| using MongoDB.Bson.Serialization.Serializers; | ||
| using MongoDB.Driver.Linq; | ||
| using Xunit; | ||
|
|
||
| namespace MongoDB.Driver.Tests.Linq.Linq3Implementation.Jira; | ||
|
|
||
| public class CSharp4040SwitchTests : LinqIntegrationTest<CSharp4040SwitchTests.ClassFixture>, IDisposable | ||
| { | ||
| static CSharp4040SwitchTests() | ||
| { | ||
| AppContext.SetSwitch("DisableCSharp4040Validation", true); | ||
|
||
|
|
||
| var discriminatorConvention = new HierarchicalDiscriminatorConvention("TypeNames"); | ||
|
|
||
| BsonClassMap.RegisterClassMap<C>(cm => | ||
| { | ||
| cm.AutoMap(); | ||
| cm.SetIsRootClass(true); | ||
| cm.SetDiscriminatorIsRequired(true); | ||
| cm.MapMember(x => x.TypeNames).SetShouldSerializeMethod(_ => false); | ||
| cm.SetDiscriminatorConvention(discriminatorConvention); | ||
|
||
| }); | ||
| } | ||
|
|
||
| public void Dispose() | ||
| { | ||
| AppContext.SetSwitch("DisableCSharp4040Validation", false); | ||
|
||
| } | ||
|
|
||
| public CSharp4040SwitchTests(ClassFixture fixture) | ||
| : base(fixture) | ||
| { | ||
| } | ||
|
|
||
| [Fact] | ||
| public void Documents_should_serializer_as_expected() | ||
| { | ||
| var collection = Fixture.Collection; | ||
|
|
||
| var seralizedDocuments = collection.AsQueryable().As(BsonDocumentSerializer.Instance).ToList(); | ||
|
|
||
| seralizedDocuments.Count.Should().Be(2); | ||
| seralizedDocuments[0].Should().Be("{ _id : 1, TypeNames : ['C', 'D'] }"); | ||
| seralizedDocuments[1].Should().Be("{ _id : 2, TypeNames : ['C', 'D', 'E'] }"); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void OfType_C_should_work() | ||
| { | ||
| var collection = Fixture.Collection; | ||
|
|
||
| var queryable = collection.AsQueryable() | ||
| .OfType<C>(); | ||
|
|
||
| var stages = Translate(collection, queryable); | ||
| AssertStages(stages, []); | ||
|
|
||
| var results = queryable.ToList(); | ||
| results.Select(x => x.Id).Should().Equal(1, 2); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void OfType_D_should_work() | ||
| { | ||
| var collection = Fixture.Collection; | ||
|
|
||
| var queryable = collection.AsQueryable() | ||
| .OfType<D>(); | ||
|
|
||
| var stages = Translate(collection, queryable); | ||
| AssertStages(stages, "{ $match : { TypeNames : 'D' } }"); | ||
|
|
||
| var results = queryable.ToList(); | ||
| results.Select(x => x.Id).Should().Equal(1, 2); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void OfType_E_should_work() | ||
| { | ||
| var collection = Fixture.Collection; | ||
|
|
||
| var queryable = collection.AsQueryable() | ||
| .OfType<E>(); | ||
|
|
||
| var stages = Translate(collection, queryable); | ||
| AssertStages(stages, "{ $match : { TypeNames : 'E' } }"); | ||
|
|
||
| var results = queryable.ToList(); | ||
| results.Select(x => x.Id).Should().Equal(2); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void Where_TypeNames_Contains_C_should_work() | ||
| { | ||
| var collection = Fixture.Collection; | ||
|
|
||
| var queryable = collection.AsQueryable() | ||
| .Where(x => x.TypeNames.Contains("C")); | ||
|
|
||
| var stages = Translate(collection, queryable); | ||
| AssertStages(stages, "{ $match : { TypeNames : 'C' } }"); | ||
|
|
||
| var results = queryable.ToList(); | ||
| results.Select(x => x.Id).Should().Equal(1, 2); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void Where_TypeNames_Contains_D_should_work() | ||
| { | ||
| var collection = Fixture.Collection; | ||
|
|
||
| var queryable = collection.AsQueryable() | ||
| .Where(x => x.TypeNames.Contains("D")); | ||
|
|
||
| var stages = Translate(collection, queryable); | ||
| AssertStages(stages, "{ $match : { TypeNames : 'D' } }"); | ||
|
|
||
| var results = queryable.ToList(); | ||
| results.Select(x => x.Id).Should().Equal(1, 2); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void Where_TypeNames_Contains_E_should_work() | ||
| { | ||
| var collection = Fixture.Collection; | ||
|
|
||
| var queryable = collection.AsQueryable() | ||
| .Where(x => x.TypeNames.Contains("E")); | ||
|
|
||
| var stages = Translate(collection, queryable); | ||
| AssertStages(stages, "{ $match : { TypeNames : 'E' } }"); | ||
|
|
||
| var results = queryable.ToList(); | ||
| results.Select(x => x.Id).Should().Equal(2); | ||
| } | ||
|
|
||
| public abstract class C | ||
| { | ||
| public int Id { get; set; } | ||
| public virtual IReadOnlyList<string> TypeNames => ["C"]; | ||
| } | ||
|
|
||
| public class D : C | ||
| { | ||
| public override IReadOnlyList<string> TypeNames => ["C", "D"]; | ||
| } | ||
|
|
||
| public class E : D | ||
| { | ||
| public override IReadOnlyList<string> TypeNames => ["C", "D", "E"]; | ||
| } | ||
|
|
||
| public sealed class ClassFixture : MongoCollectionFixture<C> | ||
| { | ||
| protected override IEnumerable<C> InitialData => | ||
| [ | ||
| new D { Id = 1 }, | ||
| new E { Id = 2 } | ||
| ]; | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this switch is not set this change has no effect so should be very safe.