Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GODRIVER-3098 Drop support for MongoDB 3.6 #1988

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

matthewdale
Copy link
Collaborator

@matthewdale matthewdale commented Mar 12, 2025

GODRIVER-3098

Summary

Drop support for MongoDB 3.6. The minimum supported MongoDB version is now 4.0.

Background & Motivation

MongoDB 3.6 reached end-of-life in 2021.

Part of a stack of changes that must be reviewed in order:

  1. GODRIVER-3445 Move all logic for skipping spec tests by description into one place. #1985
  2. GODRIVER-3098 Sync SDAM spec tests at 348d2f39. #1986
  3. GODRIVER-3098 Drop support for MongoDB 3.6 #1988 (this PR)

@mongodb-drivers-pr-bot mongodb-drivers-pr-bot bot added the priority-3-low Low Priority PR for Review label Mar 12, 2025
Copy link
Contributor

API Change Report

No changes found!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request drops support for MongoDB 3.6 by raising the minimum supported version to 4.0. Key changes include updating test skip logic, revising version checks and comments in various options and driver utilities, and updating evergreen configurations and documentation accordingly.

Reviewed Changes

Copilot reviewed 249 out of 249 changed files in this pull request and generated no comments.

Show a summary per file
File Description
internal/spectest/skip.go New file containing a skip map for tests with updated reasons tailored for MongoDB 4.0+
internal/integration/unified_spec_test.go Removed obsolete skip logic and added a call to spectest.CheckSkip
internal/integration/unified_spec_runner.go Removed the legacy skippedTests map to rely solely on the new skip mechanism
internal/driverutil/description.go Updated the minimum wire version from 6 to 7 to match the new driver requirements
README.md Updated the supported MongoDB version from “3.6 and higher” to “4.0 and higher”
internal/serverselector/server_selector_test.go Simplified test naming by removing unnecessary filename manipulation
internal/integration/causal_consistency_test.go Removed tests specific to unsupported causal consistency behavior in legacy deployments
.evergreen/config.yml Removed configurations for MongoDB 3.6 and retained only the setups for version 4.0
bson/bson_corpus_spec_test.go Minor updates to test naming and test run invocation structure
internal/integration/index_view_test.go Removed an outdated version check block for index specifications
mongo/options/* Multiple options files: updated comments to remove outdated server version restrictions
mongo/bulk_write_models.go Refactored SetHint comments to reflect updated version support requirements
mongo/database.go Updated Aggregate method documentation to remove obsolete version constraints
Comments suppressed due to low confidence (1)

internal/driverutil/description.go:24

  • Ensure that updating MinWireVersion from 6 to 7 is compatible with all version‐dependent logic in the driver to prevent any unintended behavior with server compatibility.
MinWireVersion = 7
qingyang-hu
qingyang-hu previously approved these changes Mar 20, 2025
@matthewdale matthewdale dismissed qingyang-hu’s stale review March 20, 2025 14:27

The merge-base changed after approval.

@qingyang-hu qingyang-hu self-requested a review March 20, 2025 15:15
@matthewdale matthewdale force-pushed the godriver3098-36-eol-v2 branch from 048fe47 to 9e9c6f1 Compare March 22, 2025 02:24
@matthewdale matthewdale added priority-2-medium Medium Priority PR for Review and removed priority-3-low Low Priority PR for Review labels Mar 22, 2025
@matthewdale matthewdale merged commit 38fb1c0 into mongodb:master Mar 24, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-2-medium Medium Priority PR for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants