use pointers to optimize equalTopologies func #2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isopov
commented
Apr 10, 2025
| servers := make([]description.Server, 100) | ||
| for i := 0; i < len(servers); i++ { | ||
| servers[i] = description.Server{ | ||
| Addr: address.Address("127.0.0." + strconv.Itoa(i) + ":27017"), |
There was a problem hiding this comment.
BTW, changing this string to
Addr: address.Address("127.0.0." + strconv.Itoa(i)),
turns benchmark results into
BenchmarkEqualTopologies
BenchmarkEqualTopologies-32 133854 8716 ns/op 35793 B/op 906 allocs/op
PASS
|
I've introduced NPD issue in my change, so I fixed it and added another test. |
isopov
commented
Apr 14, 2025
| } | ||
|
|
||
| if len(topoServers) != len(otherServers) { | ||
| return false | ||
| } | ||
|
|
||
| for _, server := range topoServers { | ||
| otherServer := otherServers[server.Addr.String()] |
There was a problem hiding this comment.
I've understood that we can reuse already computed canonical string for the address from the map key.
Benchmarking (different machine from previous results) produce slight improvement:
- Before
BenchmarkEqualTopologies
BenchmarkEqualTopologies-10 281943 4715 ns/op 6992 B/op 6 allocs/op
PASS
- After
BenchmarkEqualTopologies
BenchmarkEqualTopologies-10 317918 4228 ns/op 6992 B/op 6 allocs/op
PASS
And with non-canonical address (address.Address("127.0.0." + strconv.Itoa(i)))
- Before
BenchmarkEqualTopologies
BenchmarkEqualTopologies-10 66252 17721 ns/op 35793 B/op 906 allocs/op
PASS
- After
BenchmarkEqualTopologies
BenchmarkEqualTopologies-10 91142 12960 ns/op 26193 B/op 606 allocs/op
PASS
So we have pretty big additional improvement for free
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize equalTopologies
Background & Motivation
In our idle service this method in about 2 hours generates about 1GB of allocations. I want to reduce CPU load on GC from this idle service.
Included benchmark on my machine produces the following results before
and after
this change.