-
Notifications
You must be signed in to change notification settings - Fork 919
GODRIVER-3573: Remove old duplicate compilation test #2257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RafaelCenzano
wants to merge
39
commits into
mongodb:master
Choose a base branch
from
RafaelCenzano:GODRIVER-3573
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+201
−221
Open
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
669e669
Remove old compilecheck test
RafaelCenzano d0d0045
Extract go versions into bash script
RafaelCenzano ce0bb58
inline go script and run go mod commands in container
RafaelCenzano dc99892
create Go 1.19 compilecheck
RafaelCenzano f523a71
Set CodeQL Go version to 1.25.0
RafaelCenzano aae2e31
Call tasks directly instead of through Taskfile
RafaelCenzano 53192c1
add TODO for future ticket GODRIVER-3723
RafaelCenzano d9739fd
Remove uneeded compiling for each arch
RafaelCenzano eebe058
Copilot Suggestions
RafaelCenzano 76252c2
clean up how the test is run/called
RafaelCenzano 9ce3b58
Increase build compilation types
RafaelCenzano 4f0f191
Remove uneeded architectures test as it is included in compile test
RafaelCenzano 3b5384f
install libmongocrypt in container for build tags
RafaelCenzano 2876500
try to correct issue with libmongocrypt
RafaelCenzano 2f2741a
try to correct issue with build
RafaelCenzano 46f7fb5
Redo the libmongocrypt implementation using the same setup as the Tas…
RafaelCenzano e04053f
try to capture dep in a different way
RafaelCenzano 4c2c5ec
run install step for libmongocrypt
RafaelCenzano 64e14ec
Update container creation
RafaelCenzano 36247d2
Fix how tests are called
RafaelCenzano ae9a44e
Update dockerfile to use go 1.25 base
RafaelCenzano 25360a6
Include inline main go file to test compilation as an import
RafaelCenzano 3090403
Tweaks to fix the test
RafaelCenzano 01e2f05
check output of go mod tidy
RafaelCenzano dab69c0
Parallelize
RafaelCenzano 41c8316
Fix the erroneous runOnRequirements CSFLE disabled check in mtest. (#…
matthewdale cc99ff8
Skip snapshot sessions tests that require the new getSnapshotTime op.…
matthewdale 6dc01a9
GODRIVER-3659 Add optin setting to await MinPoolSize population (#2258)
prestonvasquez 66275a5
GODRIVER-3690 Add ErrorCodesFrom to the mongo package (#2241)
prestonvasquez 474da0f
GODRIVER-3486 Support auto encryption in unified tests. (#2240)
qingyang-hu d243498
resolve go.mod issue
RafaelCenzano 990c738
Address comments
RafaelCenzano 411d243
Bump actions/upload-artifact from 5.0.0 to 6.0.0 in the actions group…
dependabot[bot] 30721a2
Skip buggy handshake metadata test. (#2270)
matthewdale 08217ae
Make architectures subtests
RafaelCenzano 7cd1211
Pin to amd64 architecture
RafaelCenzano 44acf46
Make improvements based off comments
RafaelCenzano 6e1d31d
Merge branch 'master' into GODRIVER-3573
RafaelCenzano fefbb99
Remove package sudo
RafaelCenzano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,10 @@ | ||
| #!/usr/bin/env bash | ||
| # run-compile-check-test | ||
| # Run compile check tests. | ||
| # Run compile check tests for all supported Go versions. | ||
| set -eu | ||
| set +x | ||
|
|
||
| echo "Running internal/test/compilecheck" | ||
| pushd internal/test/compilecheck | ||
| GOWORK=off go test -timeout 30m -v ./... >>../../../test.suite | ||
| go test -timeout 30m -v ./... >>../../../test.suite | ||
| popd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[blocking] We need to include the libmongocrypt task before building:
If this doesn't work, try running the script manually:
If we have to do the latter, we should remove taskfile support: