make use of @ParameterizedClass feature (since JUnit 5.13) to simplify tests #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanQingyangXu
requested review from
katcharov
and removed request for
a team
src/integrationTest/java/com/mongodb/hibernate/ArrayAndCollectionIntegrationTests.java
Outdated
Show resolved
Hide resolved
NathanQingyangXu
requested review from
stIncMale
and removed request for
katcharov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JUnit5 introduced the long-awaited class level parameterized testing feature since 5.13.3. This PR makes use of this handy feature to simplify our four JDBC related integration testing classes.
To enjoy the new version, Hibernate ORM library needs to bump its version accordingly (otherwise some lazy loadin related runtime exception would be thrown for
hibernate-testingis coupled with JUnit internal` during integration testing). The new version fixed some existing bugs, so some outdated Unsupported testing case has to be removed.