PYTHON-5313 Create Evergreen tests that do not run orchestration #2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e3d99bd.
blink1073
commented
Apr 14, 2025
| @@ -206,6 +206,7 @@ async def _init_client(self): | |||
| if os.environ.get("TEST_DATA_LAKE"): | |||
| self.is_data_lake = True | |||
| self.auth_enabled = True | |||
| await self.client.close() | |||
There was a problem hiding this comment.
This was a bug that was caught when running on pypy, it raised an error during teardown.
There was a problem hiding this comment.
So we get an existing connection, close it and then establish a new connection?
Is this because the GC isn't calling close properly?
There was a problem hiding this comment.
The GC is working as intended, it just raises a warning that close() wasn't called. Yeah, we need a new client with new options.
blink1073
changed the title
Jibola
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch build: https://spruce.mongodb.com/version/67fd3570f960180007a4d9f7/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC