PYTHON-5356 - Init unified test client SDAM for all unified tests #2325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
requested changes
May 8, 2025
test/asynchronous/unified_format.py
Outdated
| @@ -303,6 +303,8 @@ async def _create_entity(self, entity_spec, uri=None): | |||
| if uri: | |||
| kwargs["h"] = uri | |||
| client = await self.test.async_rs_or_single_client(**kwargs) | |||
| if init_client: | |||
| await client.aconnect() | |||
There was a problem hiding this comment.
We can remove init_client and always call aconnect() here, since aconnect() doesn't run any commands it's always safe to start SDAM tasks. If we added an explicit client.admin.command() then we would need the init_client flag.
There was a problem hiding this comment.
Do we actually want to call client.admin.command() instead? That would ensure we actually connect with a non-SDAM connection before the test.
There was a problem hiding this comment.
I suspect that will cause problems with event monitoring. We plan to add "ping" explicitly to the unified tests themselves to fix that.
NoahStapp
changed the title
ShaneHarvey
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly connect clients for unified CSOT tests before the test begins to minimize flakiness caused by SDAM creation and startup.
Patch build with everything run: https://spruce.mongodb.com/version/6812632b5456710007edc380/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC