RUST-1992 Update the driver for bson cstr API changes #1412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abr-egn
commented
Jul 8, 2025
src/client/executor.rs
Outdated
| @@ -320,10 +320,11 @@ impl Client { | |||
| .and_then(|s| s.transaction.pinned_mongos()) | |||
| .or_else(|| op.selection_criteria()); | |||
|
|
|||
| let op_name: &str = op.name().into(); | |||
There was a problem hiding this comment.
op.name().as_str() would be the easier way to spell this but unfortunately that doesn't compile for bson 2.x when op.name() is a str itself because str::as_str isn't stabilized yet 😞 (rust-lang/rust#130366)
| @@ -108,7 +109,7 @@ pub(crate) trait Operation { | |||
| type O; | |||
|
|
|||
| /// The name of the server side command associated with this operation. | |||
| const NAME: &'static str; | |||
| const NAME: &'static CStr; | |||
There was a problem hiding this comment.
In the large majority of cases, NAME is primarily used as a key in rawdoc! construction.
isabelatkinson
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-1992
This involved unwinding all the fallibility I'd introduced in #1401, and introducing a compatibility layer for
CStrthat redirects to plainstrfor bson 2.x.