Skip to content

SERVER-110068: Modernize dynamic module loading to work with Python3.12 #1619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v7.0
Choose a base branch
from
+9 −11
Open

SERVER-110068: Modernize dynamic module loading to work with Python3.12 #1619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions buildscripts/moduleconfig.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
__all__ = ('discover_modules', 'discover_module_directories', 'configure_modules',
'register_module_test') # pylint: disable=undefined-all-variable

import imp
import importlib
import inspect
import os

Expand Down Expand Up @@ -68,16 +68,14 @@ def discover_modules(module_root, allowed_modules):

try:
print("adding module: %s" % (name))
fp = open(build_py, "r")
try:
module = imp.load_module("module_" + name, fp, build_py,
(".py", "r", imp.PY_SOURCE))
if getattr(module, "name", None) is None:
module.name = name
found_modules.append(module)
found_module_names.append(name)
finally:
fp.close()
spec = importlib.util.spec_from_file_location("module_" + name, build_py)
module = importlib.util.module_from_spec(spec)
spec.loader.exec_module(module)

if getattr(module, "name", None) is None:
module.name = name
found_modules.append(module)
found_module_names.append(name)
except (FileNotFoundError, IOError):
pass

Expand Down