-
Notifications
You must be signed in to change notification settings - Fork 14
[CLOUDP-338093] Use goreleaser
to build kubectl-mongodb
plugin for dev/staging workflows
#320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
viveksinghggits
wants to merge
3
commits into
master
Choose a base branch
from
kubectl-plugin-goreleaser
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCK 1.3.0 Release NotesBug Fixes
Other Changes
|
viveksinghggits
commented
Aug 7, 2025
8fa4b79
to
8c147ec
Compare
goreleaser
to build kubectl-mongodb
plugin for dev/staging workflows
…to build kubectl mongodb binary
8c147ec
to
8404bc1
Compare
viveksinghggits
commented
Aug 19, 2025
nammn
reviewed
Aug 22, 2025
3 tasks
nammn
approved these changes
Aug 22, 2025
mircea-cosbuc
requested changes
Aug 22, 2025
mircea-cosbuc
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Per current implementation when we release the binary we build it via goreleaser but in our dev and staging workflows we used
scripts/evergreen/build_multi_cluster_kubeconfig_creator.sh
(which eventually rungo build
) to build the binary. We needed to change this to make sure that we are using the same mechanism to build the binary in dev/staging workflows that we use while releasing. In order to achieve that, this PR adds functionality to build thekubectl-mongodb
plugin using goreleaser in dev/staging workflows.As part of the new workflow,
build_multi_cluster_binary
evergreen function has been changed to rungoreleaser build
and upload the artifacts to a S3 location. After that the linux/amd64 distribution of the binary is downloaded locally at the path where tests image expects it.Having the binary in the S3 bucket would eventually help us to just promote the binaries while the release process but we are not able to achieve that for now, because for dev/staging workflows we are not able to notarize the generated binaries.
After this PR, potentially we can even consider just getting rid of the script
scripts/evergreen/build_multi_cluster_kubeconfig_creator.sh
.Proof of Work
Run the local patch using
and make sure that test image is built successfully and the goreleaser artifacts are uploaded to the S3 bucket (
mongodb-kubernetes-dev
) correctly.CI passing on this PR also proves that the binary is successfully built and copied to the test image.
Checklist
skip-changelog
label if not needed