CLOUDP-290847: Refactor common controller's updateOmAuthentication
#371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1kola
added
the
skip-changelog
* The method now accepts a value of type `corev1.SecretKeySelector` instead of an optional secret name string. * Controllers using this method now explicitly provide a `corev1.SecretKeySelector`, replacing the previous implicit `""`.
m1kola
force-pushed
the
refactor_updateOmAuthentication
branch
from
05a0f12 to
9f762a1
Compare
m1kola
requested review from
MaciejKaras,
viveksinghggits and
nammn
and removed request for
MaciejKaras
|
Marking as ready for review. I think all the failing tests are related to the known issues (e.g. linting is broken, issues in the cloudqa environment). But just to be on the safe side, I'll merge only after at least cloudqa test issues are resolved. |
nammn
approved these changes
Aug 27, 2025
anandsyncs
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
corev1.SecretKeySelectorinstead of an optional secret name string.corev1.SecretKeySelector, replacing the previous implicit"".Note
This is a refactoring, but it is required for CLOUDP-290847 to solve the issue with agent certificate rotation. I'm moving it into a separate PR to make the actual fix PR easier to review.
Proof of Work
CI must be green
Checklist
skip-changeloglabel if not needed