-
Notifications
You must be signed in to change notification settings - Fork 17
CLOUDP-342319 - Fix proxy env vars #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MCK 1.3.0 Release NotesNew FeaturesMulti-Architecture SupportWe've added comprehensive multi-architecture support for the kubernetes operator. This enhancement enables deployment on IBM Power (ppc64le) and IBM Z (s390x) architectures alongside
Bug Fixes
Other Changes
|
@@ -145,11 +145,6 @@ else | |||
fi | |||
|
|||
|
|||
|
|||
if [[ -n "${HTTP_PROXY-}" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! I wanted to remove this one ages ago. That just makes no sense - since the go lib gets those from the env var anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but let's link mms-automation code here for code reference for the future? I assume/remember that they create the http client including the proxy
transport := &http.Transport{
Proxy: http.ProxyFromEnvironment,
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM let's add some comments here in pr for future reference, wdyt?
@@ -145,11 +145,6 @@ else | |||
fi | |||
|
|||
|
|||
|
|||
if [[ -n "${HTTP_PROXY-}" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but let's link mms-automation code here for code reference for the future? I assume/remember that they create the http client including the proxy
transport := &http.Transport{
Proxy: http.ProxyFromEnvironment,
}
Summary
This PR fixes a bug where the mongodb agents were not using the
NO_PROXY
environment variable set on the operator. This is an issue with the agent where setting thehttpProxy
flag will ignore the environment variables. Therefore, running the agent without that flag work properly whether the variables are set or not.To make sure this is tested, the
e2e_operator_proxy
test was updated by adding aNO_PROXY
variable set to cloud-qa and asserting that the proxy does not intercept those calls.Proof of Work
Ran a patch where the test was updated, but the fix was not added. It failed, proving that the setting the
NO_PROXY
variable did not work.With the fix, the CI should be green.
Checklist
skip-changelog
label if not needed