Skip to content

Fix linting ct lint issue in helm chart #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 3, 2025
Merged

Fix linting ct lint issue in helm chart #487

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2eff0cf
Fix linting `ct lint` issue in helm chart
viveksinghggits Oct 1, 2025
4901987
Address review comments
viveksinghggits Oct 2, 2025
fb30b49
Fix review comments'
viveksinghggits Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions .githooks/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,11 +226,19 @@ pre_commit() {
run_job_in_background "python_formatting"
run_job_in_background "check_erroneous_kubebuilder_annotations"
run_job_in_background "validate_snippets"
run_job_in_background "lint_helm_chart"

if wait_for_all_background_jobs; then
echo -e "${GREEN}pre-commit: All checks passed!${NO_COLOR}"
return 0
# lint_helm_chart must be run after all the background jobs are finished because one of the BG jobs (update_jobs)
# updates the helm chart. And lint_helm_chart requires the helm chart to be updated already.
lint_helm_chart

local lint_helm_chart_status=$?
if [ "$lint_helm_chart_status" -eq 0 ]; then
return 0
echo -e "${GREEN}pre-commit: All checks passed!${NO_COLOR}"
else
return 1
fi
else
return 1
fi
Expand Down