Reduce Evergreen retries to 1 #491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCK 1.5.0 Release NotesNew Features
Bug Fixes
|
Julien-Ben
commented
Oct 2, 2025
| fi | ||
|
|
||
| EVERGREEN_API="https://evergreen.mongodb.com/api" | ||
| MAX_RETRIES="${EVERGREEN_MAX_RETRIES:-3}" |
There was a problem hiding this comment.
We had this env variable set to 2 in the Evergreen project settings, for some reason it was not picked up by the script, so I just left an hardcoded value.
There was a problem hiding this comment.
Don't we need to have it inside an include_expansions_in_env block for the task?
There was a problem hiding this comment.
Probably, do we think we need an env variable for that ?
Julien-Ben
commented
Oct 2, 2025
| echo "Finding failed tasks in BUILD ID: ${BUILD_ID}" | ||
| # shellcheck disable=SC2207 | ||
| TASK_IDS=($(curl -s -H "Api-User: ${EVERGREEN_USER}" -H "Api-Key: ${EVERGREEN_API_KEY}" ${EVERGREEN_API}/rest/v2/builds/"${BUILD_ID}"/tasks | jq ".[] | select(.status == \"failed\" and .execution <= ${MAX_RETRIES})" | jq -r '.task_id')) | ||
| TASK_IDS=($(curl -s -H "Api-User: ${EVERGREEN_USER}" -H "Api-Key: ${EVERGREEN_API_KEY}" ${EVERGREEN_API}/rest/v2/builds/"${BUILD_ID}"/tasks | jq ".[] | select(.status == \"failed\" and .execution < ${MAX_RETRIES})" | jq -r '.task_id')) |
There was a problem hiding this comment.
.execution is the id from the last failing task. Executions are 0-indexed
Julien-Ben
added
the
skip-changelog
anandsyncs
approved these changes
Oct 2, 2025
mircea-cosbuc
approved these changes
Oct 2, 2025
| fi | ||
|
|
||
| EVERGREEN_API="https://evergreen.mongodb.com/api" | ||
| MAX_RETRIES="${EVERGREEN_MAX_RETRIES:-3}" |
There was a problem hiding this comment.
Don't we need to have it inside an include_expansions_in_env block for the task?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of five total attempts for end-to-end tests, let's reduce it to two. Decided in today's Discuss meeting, 02/10/25
Proof of Work
Failing tests must restart only once.