CLOUDP-350375: MongoDBMultiCluster: Add annotation to disable reconciliation
#511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1kola
changed the title
MongoDBMultiCluster: Add annotation to disable reconciliationMongoDBMultiCluster: Add annotation to disable reconciliation
m1kola
force-pushed
the
add-disable-reconciliation-annotation
branch
from
96ca920 to
a1095fa
Compare
m1kola
added
the
skip-changelog
m1kola
commented
Oct 9, 2025
| return reconcileResult, err | ||
| } | ||
|
|
||
| if val, ok := mrs.Annotations[util.DisableReconciliation]; ok && val == util.DisableReconciliationValue { |
There was a problem hiding this comment.
It will be something our users will be using during migration, but as part of this PR I"m not going to document the annotation/add a release note. It will be included in the migration guide once we release a version which is ready for migration. Until then - let's leave it undocumented.
m1kola
commented
Oct 9, 2025
| LastAchievedRsMemberIds = "mongodb.com/v1.lastAchievedRsMemberIds" | ||
|
|
||
| DisableReconciliation = "mongodb.com/v1.disableReconciliation" | ||
| DisableReconciliationValue = "true" |
There was a problem hiding this comment.
Had to define a constant because linter was not happy.
m1kola
force-pushed
the
add-disable-reconciliation-annotation
branch
from
a1095fa to
24ec913
Compare
The new `mongodb.com/v1.disable-reconciliation` annotation allows disabling reconciliation for `MongoDBMultiCluster` objects. This will be used later when migrating multi-cluster replica sets from `MongoDBMultiCluster` to `MongoDB`.
m1kola
force-pushed
the
add-disable-reconciliation-annotation
branch
from
24ec913 to
72152af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The new
mongodb.com/v1.disable-reconciliationannotation allows disabling reconciliation forMongoDBMultiClusterobjects.This will be used later when migrating multi-cluster replica sets from
MongoDBMultiClustertoMongoDB.Proof of Work
mongodb.com/v1.disableReconciliationto anyMongoDBMultiClusterkubectl wait mongodbmulticluster NAME -n NAMESPACE --for=jsonpath='{.status.phase}'=Disabled.kubectl waitcommand printsmongodbmulticluster.mongodb.com/NAME condition met.Checklist
skip-changeloglabel if not needed