Skip to content

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Sep 2, 2025

Proposed changes

Cleanup unmaintained examples: quickstart-mongodb-atlas, quickstart-mongodb-atlas-mean-stack-aws-fargate-integration, quickstart-mongodb-atlas-analytics-amazon-sagemaker-integration

Jira ticket: CLOUDP-342276

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Manual QA performed:

  • cfn invoke for each of CRUDL/cfn test
  • Updated resource in example
  • Published to AWS private registry
  • Used the template in example to create and update a stack in AWS
  • Deleted stack to ensure resources are deleted
  • Created multiple resources in same stack
  • Validated in Atlas UI
  • Included screenshots

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • For CFN Resources: I have released by changes in the private registry and proved by change
    works in Atlas

Further comments

@Copilot Copilot AI review requested due to automatic review settings September 2, 2025 16:41
@lantoli lantoli requested a review from a team as a code owner September 2, 2025 16:41
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes three unmaintained quickstart examples from the MongoDB Atlas CloudFormation resources repository:

  • Cleanup of outdated MongoDB Atlas integration examples
  • Removal of unused quickstart templates and supporting code
  • Elimination of obsolete documentation and configuration files

Reviewed Changes

Copilot reviewed 52 out of 57 changed files in this pull request and generated no comments.

File Description
quickstart-mongodb-atlas/ Complete removal of basic quickstart example including README, execution role template
quickstart-mongodb-atlas-mean-stack-aws-fargate-integration/ Full deletion of MEAN stack Fargate integration example with client/server code, Docker configs, and documentation
quickstart-mongodb-atlas-analytics-amazon-sagemaker-integration/ Complete removal of SageMaker analytics integration example including ML model code, Lambda functions, and supporting files
Files not reviewed (1)
  • examples/quickstart-mongodb-atlas-mean-stack-aws-fargate-integration/fargate-example/package-lock.json: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@oarbusi oarbusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

This reverts commit 4af4d3a.
@lantoli lantoli added this pull request to the merge queue Sep 3, 2025
Merged via the queue into master with commit c8c265e Sep 3, 2025
36 checks passed
@lantoli lantoli deleted the CLOUDP-342276_cleanup_examples branch September 3, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants