MONGOID-5885 Return value from transaction yield to caller instead of internal state - #6030
Merged
comandeo-mongo merged 1 commit intoAug 25, 2025
Merged
Conversation
…te (mongodb#6005) Co-authored-by: Dmitry Rybakov <160598371+comandeo-mongo@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the return value of the Mongoid.transaction method to return the value yielded from the block instead of internal state. Previously, the method was returning the result of run_commit_callbacks rather than the block's return value.
Key changes:
- Modified the transaction method to properly return the block's yield value
- Added test coverage to verify the correct return value behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/mongoid/clients/sessions.rb | Fixed transaction method to return block value using tap to preserve return value while running callbacks |
| spec/mongoid/clients/transactions_spec.rb | Added test to verify transaction returns the block's value and restructured existing test setup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jamis
approved these changes
Aug 25, 2025
This was referenced Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.