Evaluate message formatting only once while formatting the log #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunkyboy
reviewed
Nov 11, 2022
| @@ -36,6 +36,10 @@ type Log struct { | |||
| MessageFmt string | |||
| Args []interface{} | |||
| Context *Context | |||
|
|
|||
| // Appendages to evaluate a message only once | |||
| message string | |||
There was a problem hiding this comment.
What is the lifecycle of a Log struct? We've now ~doubled the effective size of it, assuming MessageFmt (and now message) is long compared to the other fields...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log.Message()can be called multiple times after theLogobject has been constructed, and each time it'll print the formatted over and over again. This PR introduces a way in which evaluation happens once, and the formatted log is stored in theLogand is returned without any cost.QA:
./run-testsshows everything in v2 passing.cc @dunkyboy