Skip to content

Conversation

caesarbell
Copy link
Collaborator

@caesarbell caesarbell commented Aug 6, 2025

Stories/Links:

DOP-6049

Current Behavior:

Put a link to current staging or production behavior, if applicable

Staging Links:

https://deploy-preview-13580--mongodb-landing.netlify.app/docs/

Notes:

This PR introduces the MultiColumn Component. This component will be used on the homepage. You can test locally by also pointing to the PR branch in the snooty-parser

side note: Waiting to also hear back from the design team on look and feel for mobile/tablet view

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

Copy link

netlify bot commented Aug 6, 2025

Deploy Preview for docs-frontend-stg ready!

Name Link
🔨 Latest commit 4106ba8
🔍 Latest deploy log https://app.netlify.com/projects/docs-frontend-stg/deploys/68a5edc2d049000008868bb4
😎 Deploy Preview https://deploy-preview-1504--docs-frontend-stg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@docs-builder-bot
Copy link

docs-builder-bot commented Aug 6, 2025

❌ Deploy Preview for docs-frontend-stg failed

Item Details
🔨 Latest Commit f12b3322f1ee56b3d15f188c68cd9a7ef4a3b162
😎 Deploy Preview https://deploy-preview-1504--docs-frontend-stg.netlify.app
🔍 Build Logs View Logs

Error Details

Build failed

Copy link
Collaborator

@biancalaube biancalaube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments but the staging link looks very nice!

"children": [
{
"type": "text",
"value": "This is a paragraph between the code blocks."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this like the final text? Or like are giving this version to the writers but they will be filling out the content

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@biancalaube this is just test data. The content comes from the writers in the src of the landing directory from the monorepo.

Copy link
Collaborator

@seungpark seungpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments below! also wondering if this is safe to release without the content change (would be good to see a regression check!)

margin-top: 60px;
margin-bottom: 40px;
@media ${theme.screenSize.upTo2XLarge} {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be lining up with tablet view? seems like it switches to vertical layout too early

&::before {
content: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="10" height="10" viewBox="0 0 10 10" fill="none"><circle cx="5" cy="5" r="4.25" stroke="%2300ED64" stroke-width="1.5"/></svg>');
position: absolute;
left: 8px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this left intentional? seems a little closer than the figma design

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The left is internal, but I needed to give it more space from the text and had to increase the spacing.

@caesarbell
Copy link
Collaborator Author

see comments below! also wondering if this is safe to release without the content change (would be good to see a regression check!)

The content will be added by the writers, but this allows them to be able to use the content. I don't think it will go pass preprd.

@caesarbell
Copy link
Collaborator Author

see comments below! also wondering if this is safe to release without the content change (would be good to see a regression check!)

Also, we did add a snapshot test as well.

@caesarbell caesarbell requested a review from seungpark August 11, 2025 22:35
Copy link
Collaborator

@seungpark seungpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments below, but overall looks good 👍

removeMargin,
}: {
nodeData: CodeNode;
removeMargin: boolean;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of removeMargin prop, can we take className and append it to the class, and style in the consuming component

import { theme } from '../../theme/docsTheme';

const MultiColumn = ({ nodeData }: { nodeData: ParentNode }) => {
console.log('nodeData', nodeData);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor, remove log

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good callout, I forgot to remove this.

@caesarbell caesarbell requested a review from seungpark August 12, 2025 15:39
@docs-builder-bot
Copy link

docs-builder-bot commented Aug 12, 2025

✅ Deploy Preview for landing ready

Item Details
🔨 Latest Commit 53531a9097d95f32204653a4cf4870625654834b
😎 Deploy Preview https://deploy-preview-1504--docs-frontend-stg.netlify.app/docs
🔍 Build Logs View Logs

@caesarbell caesarbell merged commit cd3d2f6 into feat/unified-nav Aug 20, 2025
1 check passed
@caesarbell caesarbell deleted the DOP-6049 branch August 20, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants