Skip to content

chore: Adjust migration tests with SA #3790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

chore: Adjust migration tests with SA #3790

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
47dedfa
allow mig tests in SA
lantoli Oct 17, 2025
821d6b2
Merge branch 'master' into CLOUDP-352095_sa_mig_tests
lantoli Oct 22, 2025
3e8c0de
no need for smoke tests anymore
lantoli Oct 23, 2025
c2f065f
don't run mig tests
lantoli Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 4 additions & 16 deletions .github/workflows/acceptance-tests-runner.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,8 +211,9 @@ env:
TF_LOG: ${{ vars.LOG_LEVEL }}
ACCTEST_TIMEOUT: ${{ vars.ACCTEST_TIMEOUT }}
# If the name (regex) of the test is set, only that test is run.
# Don't run migration tests if using Service Accounts because previous provider versions don't support SA yet.
# Only Migration tests are run when a specific previous provider version is set.
# Don't run migration tests if using Service Account because each migration test creates a new SA token in the test first step.
# The previous provider runs externally (equivalent to running a Terraform command), causing token creation limit issues.
ACCTEST_REGEX_RUN: ${{ inputs.test_name || inputs.use_sa && '^TestAcc' || inputs.provider_version == '' && '^Test(Acc|Mig)' || '^TestMig' }}
MONGODB_ATLAS_BASE_URL: ${{ inputs.mongodb_atlas_base_url }}
MONGODB_REALM_BASE_URL: ${{ inputs.mongodb_realm_base_url }}
Expand Down Expand Up @@ -427,7 +428,7 @@ jobs:

advanced_cluster_tpf_mig_from_sdkv2:
needs: [ change-detection, get-provider-version ]
# Previous advanced_cluster versions don't support SA.
# advanced_cluster v1.x versions don't support SA.
if: ${{ inputs.reduced_tests == false && inputs.use_sa == false && (needs.change-detection.outputs.advanced_cluster == 'true' || inputs.test_group == 'advanced_cluster') }}
runs-on: ubuntu-latest
permissions: {}
Expand All @@ -453,7 +454,7 @@ jobs:

advanced_cluster_tpf_mig_from_tpf_preview:
needs: [ change-detection, get-provider-version ]
# Previous advanced_cluster versions don't support SA.
# advanced_cluster v1.x versions don't support SA.
if: ${{ inputs.reduced_tests == false && inputs.use_sa == false && (needs.change-detection.outputs.advanced_cluster == 'true' || inputs.test_group == 'advanced_cluster') }}
runs-on: ubuntu-latest
permissions: {}
Expand Down Expand Up @@ -594,19 +595,6 @@ jobs:
ACCTEST_REGEX_RUN: '^TestAccAccessToken'
ACCTEST_PACKAGES: ./internal/provider
run: make testacc
- name: Acceptance Tests (Service Account smoke tests) # small selection of fast tests to run with SA
env:
MONGODB_ATLAS_PUBLIC_KEY: ""
MONGODB_ATLAS_PRIVATE_KEY: ""
MONGODB_ATLAS_CLIENT_ID: ${{ secrets.mongodb_atlas_client_id }}
MONGODB_ATLAS_CLIENT_SECRET: ${{ secrets.mongodb_atlas_client_secret }}
MONGODB_ATLAS_LAST_VERSION: ${{ needs.get-provider-version.outputs.provider_version }}
ACCTEST_REGEX_RUN: '^TestAcc' # Don't run migration tests because previous provider versions don't support SA.
ACCTEST_PACKAGES: |
./internal/service/alertconfiguration
./internal/service/databaseuser
./internal/service/maintenancewindow
run: make testacc

autogen_fast:
needs: [change-detection, get-provider-version]
Expand Down