refactor: Uses delete_on_create_timeout with default=true support across TPF resources #3809

EspenAlbert · 2025-10-23T08:12:41Z

Description

Uses delete_on_create_timeout with default=true support across TPF resources

Link to any related issue(s): CLOUDP-343190

Type of change:

Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
This change requires a documentation update
Documentation fix/enhancement

Required Checklist:

I have signed the MongoDB CLA
I have read the contributing guides
I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
I have added any necessary documentation (if appropriate)
I have run make fmt and formatted my code
If changes include deprecations or removals I have added appropriate changelog entries.
If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

…PF resources

…tiple resources

… behavior

EspenAlbert · 2025-10-23T09:07:49Z

internal/service/searchdeployment/resource_test.go

 				Config: updateStepNoWait,
 				Check:  updateStep.Check,
 			},
-			// Changes: skip_wait_on_update true -> null


This summarizes the change in behavior well.
The old way allowed updating to null while the new way keeps the state value if removed (UseStateForUnknown behavior).

This is why we need the ImportStateVerifyIgnore: []string{"delete_on_create_timeout"} in import as it will not be present in the state after import.
Because once the value has been used in create it remains unchanged.

Note: A fresh import and setting delete_on_create_timeout in the config will raise an update error saying it cannot be updated.

EspenAlbert · 2025-10-23T09:10:36Z

internal/service/searchdeployment/resource_test.go

-				Config: configWithTimeout(timeoutsStrLongFalse),
-				Check:  resource.TestCheckResourceAttr(resourceID, "delete_on_create_timeout", "false"),
+				Config:      configWithTimeout(timeoutsStrLongFalse),
+				ExpectError: regexp.MustCompile("delete_on_create_timeout cannot be updated or set after import .*"),


Example of error message when trying to update

…and fix extra space in error message for delete_on_create_timeout

…fault

Copilot

Pull Request Overview

This PR refactors the delete_on_create_timeout attribute across multiple TPF (Terraform Plugin Framework) resources to use a new plan modifier CreateOnlyBoolWithDefault(true) that provides a default value of true, making the attribute computed. This standardizes the behavior across resources including stream processors, search deployments, push-based log exports, encryption-at-rest private endpoints, and advanced clusters.

Key Changes:

Replaced customplanmodifier.CreateOnly() with customplanmodifier.CreateOnlyBoolWithDefault(true) for the delete_on_create_timeout attribute
Added Computed: true to the delete_on_create_timeout schema attribute
Removed the ResolveDeleteOnCreateTimeout helper function, directly using ValueBool() instead

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
internal/service/streamprocessor/resource_schema.go	Updated schema to make delete_on_create_timeout computed with default true
internal/service/streamprocessor/resource.go	Changed to use ValueBool() directly instead of ResolveDeleteOnCreateTimeout
internal/service/streamprocessor/resource_test.go	Added delete_on_create_timeout to import verify ignore list and refactored import steps
internal/service/searchdeployment/resource_schema.go	Updated schema to make delete_on_create_timeout computed with default true
internal/service/searchdeployment/resource.go	Changed to use ValueBool() directly instead of ResolveDeleteOnCreateTimeout
internal/service/searchdeployment/resource_test.go	Updated tests to handle delete_on_create_timeout as computed attribute
internal/service/pushbasedlogexport/resource_schema.go	Updated schema to make delete_on_create_timeout computed with default true
internal/service/pushbasedlogexport/resource.go	Changed to use ValueBool() directly instead of ResolveDeleteOnCreateTimeout
internal/service/pushbasedlogexport/resource_test.go	Added delete_on_create_timeout to import verify ignore list
internal/service/encryptionatrestprivateendpoint/resource_schema.go	Updated schema to make delete_on_create_timeout computed with default true
internal/service/encryptionatrestprivateendpoint/resource.go	Changed to use ValueBool() directly instead of ResolveDeleteOnCreateTimeout
internal/service/encryptionatrestprivateendpoint/resource_test.go	Added delete_on_create_timeout to import verify ignore list and refactored import steps
internal/service/advancedcluster/schema.go	Updated schema to make delete_on_create_timeout computed with default true
internal/service/advancedcluster/resource.go	Changed to use ValueBool() directly instead of ResolveDeleteOnCreateTimeout
internal/common/cleanup/handle_timeout.go	Removed ResolveDeleteOnCreateTimeout helper function

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

marcosuma · 2025-10-24T09:45:14Z

internal/service/advancedcluster/resource.go

 	projectID, clusterName := waitParams.ProjectID, waitParams.ClusterName
 	clusterDetailStr := fmt.Sprintf("Cluster name %s (project_id=%s).", clusterName, projectID)
-	if cleanup.ResolveDeleteOnCreateTimeout(plan.DeleteOnCreateTimeout) {
+	if plan.DeleteOnCreateTimeout.ValueBool() {


can plan.DeleteOnCreateTimeout be null?

No, it has a default value of true

marcosuma · 2025-10-24T09:46:11Z

internal/service/advancedcluster/schema.go

 			},
 			"delete_on_create_timeout": schema.BoolAttribute{
-				Optional:            true,
+				Computed: true,


I see we're adding computed but we're also adding the plan modifier. I would like certainty that we're not adding one more field to the output plan that says known after apply. We're getting a few GH issues lately talking about the plan verbosity

Actually this PR improves that behavior by showing the planned true value (see doc)

manupedrozo · 2025-10-24T15:15:11Z

internal/service/streamprocessor/resource_test.go

 	testLogDestConfig    = connectionConfig{connectionType: connTypeTestLog, pipelineStepIsSource: false}
 )

+func importStep() resource.TestStep {


Can be a var as well. Same as in resource_database_user_test.go

i normally prefer functions to global vars, which is safer in case the var is modified later and might affect other tests. (some exceptions apply, e.g. for an array of strings, if we're sure they're not modified)

EspenAlbert added 3 commits October 23, 2025 09:09

refactor: Uses delete_on_create_timeout with default support across T…

c7497f3

…PF resources

test: Add delete_on_create_timeout to ImportStateVerifyIgnore for mul…

5c6f18c

…tiple resources

test: Update timeout test to validate delete_on_create_timeout update…

63f827c

… behavior

EspenAlbert commented Oct 23, 2025

View reviewed changes

EspenAlbert added 2 commits October 23, 2025 16:28

test: Enhance search deployment tests to include stable state checks …

468d6a0

…and fix extra space in error message for delete_on_create_timeout

Merge branch 'master' into CLOUDP-343190_tpf_delete_on_create_with_de…

c89d6c8

…fault

EspenAlbert marked this pull request as ready for review October 24, 2025 08:45

EspenAlbert requested a review from a team as a code owner October 24, 2025 08:45

Copilot AI review requested due to automatic review settings October 24, 2025 08:45

Copilot AI reviewed Oct 24, 2025

View reviewed changes

marcosuma reviewed Oct 24, 2025

View reviewed changes

manupedrozo reviewed Oct 24, 2025

View reviewed changes

manupedrozo approved these changes Oct 24, 2025

View reviewed changes

lantoli approved these changes Oct 27, 2025

View reviewed changes

EspenAlbert merged commit 6839dd0 into master Oct 27, 2025
50 checks passed

EspenAlbert deleted the CLOUDP-343190_tpf_delete_on_create_with_default branch October 27, 2025 08:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor: Uses delete_on_create_timeout with default=true support across TPF resources #3809

refactor: Uses delete_on_create_timeout with default=true support across TPF resources #3809

Uh oh!

EspenAlbert commented Oct 23, 2025

Uh oh!

EspenAlbert Oct 23, 2025 •

edited

Loading

Uh oh!

EspenAlbert Oct 23, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

marcosuma Oct 24, 2025

Uh oh!

EspenAlbert Oct 24, 2025

Uh oh!

marcosuma Oct 24, 2025

Uh oh!

EspenAlbert Oct 24, 2025

Uh oh!

manupedrozo Oct 24, 2025

Uh oh!

lantoli Oct 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

refactor: Uses delete_on_create_timeout with default=true support across TPF resources #3809

refactor: Uses delete_on_create_timeout with default=true support across TPF resources #3809

Uh oh!

Conversation

EspenAlbert commented Oct 23, 2025

Description

Type of change:

Required Checklist:

Further comments

Uh oh!

EspenAlbert Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EspenAlbert Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

marcosuma Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

EspenAlbert Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

marcosuma Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

EspenAlbert Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

manupedrozo Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

lantoli Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

EspenAlbert Oct 23, 2025 •

edited

Loading

lantoli Oct 27, 2025 •

edited

Loading