feat: Private Link Online Archive add Azure support by marcabreracast · Pull Request #4355 · mongodb/terraform-provider-mongodbatlas

marcabreracast · 2026-03-31T15:32:16Z

Description

This PR adds Azure support for mongodbatlas_privatelink_endpoint_service_data_federation_online_archive.

Azure fields introduced (already present in autogen code)

As part of Azure support, we are documenting fields that are already defined in the autogenerated implementation.
The following fields are already present in autogen schema/model.

customer_endpoint_ip_address: IP address used to connect to the Azure private endpoint.
azure_link_id: Link ID that identifies the Azure private endpoint connection.
error_message: Error message returned when private endpoint approval/connection fails.
status: Current status of the private endpoint connection request.

Additional changes:

Adds Azure acceptance coverage for the resource
Adds Azure data source acceptance (singular and plural) mirroring the AWS behavior checks.
Adds/refactors test config helpers to keep AWS/Azure test config generation consistent.
Adds a full Azure example for Data Federation + Online Archive.

Link to related issue(s):

https://jira.mongodb.org/browse/CLOUDP-389847

Blocker

This PR is pending https://jira.mongodb.org/browse/CLOUDP-391704.

We should not merge this PR until CLOUDP-391704 is resolved and behaviour is verified as expected.

Link to any related issue(s): CLOUDP-329593

Type of change:

Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
This change requires a documentation update
Documentation fix/enhancement

Required Checklist:

I have signed the MongoDB CLA
I have read the contributing guides
I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
I have added any necessary documentation (if appropriate)
I have run make fix and verified my code
If changes include deprecations or removals I have added appropriate changelog entries.
If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

… to run in CI and adjust autogen testing

… model

…_LiftAndShift_Replace_Manual_Resource_With_Autogen

marcabreracast · 2026-03-31T16:37:59Z

          MONGODB_ATLAS_PRIVATE_ENDPOINT_DNS_NAME: ${{ secrets.mongodb_atlas_private_endpoint_dns_name }}
          MONGODB_ATLAS_PRIVATE_ENDPOINT_ID: ${{ secrets.mongodb_atlas_private_endpoint_id }}
          MONGODB_ATLAS_PRIVATE_ENDPOINT_ID_REPLACE: ${{ secrets.mongodb_atlas_private_endpoint_id_replace }}
+          MONGODB_ATLAS_PRIVATE_ENDPOINT_ID_AZURE: ${{ secrets.mongodb_atlas_private_endpoint_id_azure }}


These variables are still not wired to the repo, however would like confirmation whether we have a pre-Azure setup that I can use for this, or use my own instead.

Would prefer the first option as we might risk having the endpoint_id removed at some point.

I see we have some azure resources used in our ci (azure_vnet_name, azure_key_vault_name, azure_resource_group_name), would suggesting seeing where those resources live and stay as consistent as possible

Yep correct, got the info I needed doing a bit of digging and added the vars for the test

github-actions · 2026-03-31T16:39:21Z

APIx bot: a message has been sent to Docs Slack channel
APIx bot: a message has been sent to Docs Slack channel

…online archive resource with autogen (#4351) * Remove _api naming from autogen resource * Register autogen resource on provider * Deregister manual resource from provider * Add migration test to autogen repo * Update acceptance test naming for autogen resource * With new endpoint ID added to repo, readding test in order to be able to run in CI and adjust autogen testing * feat: Add privatelink endpoint service data federation online archive model * Add missing secret to avoid lint issue * Add missing secret to acceptance tests workflow * Fix status field to keep being Computed * Remove api autogen file to avoid test errors * Add changelog for new supported import format * Strip status field from CREATE request * Fix tests pointing to wrong resource * Update docs to reflect on import support behaviour * Fix changelog * Address doc comments * Rename test files to match autogen pattern * Remove manual resource, as it's no longer used * Send status field hardcoded on CREATE * Remove manual acceptance tests from network block * Refactor acceptance tests * Move config to top of file

…re-support

…mmented out

…due to Azure limitations

EspenAlbert · 2026-04-07T19:48:37Z

@@ -0,0 +1,5 @@
+```release-note:enhancement
+resource/mongodbatlas_privatelink_endpoint_service_data_federation_online_archive: Adds Azure support, including `customer_endpoint_ip_address`, `azure_link_id`, `error_message`, and `status`


should be three different entries

EspenAlbert · 2026-04-07T19:52:19Z

          status:
            computability:
              computed: true
+          azure_link_id:


Maybe add a quick why this is necessary?

EspenAlbert · 2026-04-07T19:53:10Z


 func (r *rs) PreImport(id string) (string, error) {
-	if strings.Contains(id, "/") {
+	// Normalized format: project_id/endpoint_id (AWS only).


Is this comment accurate?

Yes, currently normalized import is only supported on AWS, not for Azure as noted in the docs. We will be keeping legacy support for both Azure and AWS though.

EspenAlbert · 2026-04-07T19:55:08Z

+	%[11]s
+	%[12]s
+	`,
+		acc.ConfigAzurermProvider(subscriptionID, clientID, clientSecret, tenantID),


this list is very long. Is it worth splitting up and instead using + between the strings?

EspenAlbert · 2026-04-07T19:56:48Z

+
+	  private_service_connection {
+	    name                           = "atlas-df-connection"
+	    private_connection_resource_id = %[7]q


where is this coming from? Is there no way we can create it within the test?

I've opened a thread with upstream team regarding this value, as I have not identify a way of retrieving this field through the Atlas Admin API so far

EspenAlbert · 2026-04-07T19:57:23Z

 	`, projectID, endpointID, comment, optionalFields, singularDataSourceConfig, pluralDataSourceConfig)
 }
+
+const singularDataSourceConfig = `


[nit] why moved from the top?

EspenAlbert · 2026-04-07T19:58:19Z

+					),
+				},
+				Check: resource.ComposeAggregateTestCheckFunc(
+					checkExists(resourceName),


refactor to use CheckRSAndDS in internal/testutil/acc/attribute_checks.go

svc-apix-Bot · 2026-04-19T00:51:53Z

This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

marcabreracast · 2026-04-22T08:24:05Z

Closed in favor of blocked status for CLOUDP-389847

marcabreracast added 20 commits March 31, 2026 09:57

Remove _api naming from autogen resource

3e715f5

Register autogen resource on provider

4313385

Deregister manual resource from provider

2d89eb8

Add migration test to autogen repo

b3f33c3

Update acceptance test naming for autogen resource

2391479

With new endpoint ID added to repo, readding test in order to be able…

87ba1f4

… to run in CI and adjust autogen testing

feat: Add privatelink endpoint service data federation online archive…

de32022

… model

Add missing secret to avoid lint issue

198ed7f

Add missing secret to acceptance tests workflow

dac653c

Fix status field to keep being Computed

f17a807

Remove api autogen file to avoid test errors

4b23ed9

Add changelog for new supported import format

2c74e4a

Merge branch 'master' into dev/CLOUDP-389847_PrivateLinkOnlineArchive…

e0358dc

…_LiftAndShift_Replace_Manual_Resource_With_Autogen

Strip status field from CREATE request

0802bc1

Fix tests pointing to wrong resource

4b97d91

Add new attributes to documentation and fix links

df6f598

Update docs

559e061

Add Azure example

b2559dd

Example tests

78ea010

Override provider_name description field to match Azure support

441fe0d

github-actions Bot added the enhancement label Mar 31, 2026

Refactor tests to include DS

b40a8cd

marcabreracast mentioned this pull request Mar 31, 2026

chore: Autogen Lift-and-shift - Replace manual resource private link online archive resource with autogen #4351

Merged

13 tasks

marcabreracast added 2 commits March 31, 2026 18:28

Add Changelog

9599167

Wiring for env vars in Acceptance tests

e947fa0

marcabreracast commented Mar 31, 2026

View reviewed changes

marcabreracast marked this pull request as ready for review March 31, 2026 16:39

marcabreracast requested review from a team as code owners March 31, 2026 16:39

marcabreracast and others added 10 commits April 1, 2026 15:54

Add data source documentation

41835cf

Fix doc for data source format

056be60

Merge branch 'dev/PrivateLink_OnlineArchive_FinalStep' into clean/azu…

c3963f2

…re-support

Refactor Azure tests, and added additional step for comment update co…

2f382af

…mmented out

Override endpoint_id description to match Azure support

84bceeb

Fix import issue for Azure

7c3d74a

Clean example and README

6f9a26b

Rework structure of example

4d232a0

Reduced timeout

31a7f57

AgustinBettati force-pushed the clean/azure-support branch from 0917ce2 to 31a7f57 Compare April 2, 2026 07:48

marcabreracast added 2 commits April 7, 2026 21:02

Refactor tests to avoid reusing endpoint_id, as this is not possible …

013ba00

…due to Azure limitations

Add note on docs for private endpoint behaviour

9e41a03

EspenAlbert reviewed Apr 7, 2026

View reviewed changes

marcabreracast added 5 commits April 8, 2026 09:05

Separate changelong entries

35c7d53

Add comment to clarify override behaviour

e8ea58a

Remove hardcoded status field

cde4744

Refactor test

b227d2a

Uncomment test checks for update behaviour on Azure

c7b7c0d

Base automatically changed from dev/PrivateLink_OnlineArchive_FinalStep to master April 13, 2026 07:06

svc-apix-Bot added the stale label Apr 19, 2026

svc-apix-Bot closed this Apr 22, 2026

		@@ -0,0 +1,5 @@
		```release-note:enhancement
		resource/mongodbatlas_privatelink_endpoint_service_data_federation_online_archive: Adds Azure support, including `customer_endpoint_ip_address`, `azure_link_id`, `error_message`, and `status`

Conversation

marcabreracast commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Azure fields introduced (already present in autogen code)

Blocker

Type of change:

Required Checklist:

Further comments

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

svc-apix-Bot commented Apr 19, 2026

Uh oh!

marcabreracast commented Apr 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

marcabreracast commented Mar 31, 2026 •

edited

Loading

github-actions Bot commented Mar 31, 2026 •

edited

Loading