Treat missing Atlas database user as successful delete - #4705
Open
Hashim1999164 wants to merge 1 commit into
Open
Hashim1999164 wants to merge 1 commit into
Hashim1999164 wants to merge 1 commit into
Conversation
When the user is already gone, Delete should succeed like Read does. Fixes mongodb#4656
Collaborator
|
Hi @Hashim1999164, I f we go with your proposed approach, following our Contributing Guidelines in regards to Merging a Pull Request, we will create a branch from this PR and cherry pick your contribution. I will keep this PR open for now so I can inform you when there's any relevant updates regarding this topic. Thank you for your patience! |
Author
|
@marcabreracast yeah that makes sense if a bunch of resources do the same thing. no rush, cherry pick is fine whenever you land on the convention. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When destroy calls Delete for mongodbatlas_database_user and Atlas returns 404 USER_NOT_FOUND, treat that as success so apply can finish. This matches Read behavior and sibling resources such as teamprojectassignment.
Closes #4656
Test plan