chore: Update summarize-test-suite skill to scope code-regression verdicts - #4720
marcabreracast wants to merge 3 commits into
Conversation
🤖 Augment PR SummarySummary: Refines the nightly test-suite skill so known recurring backend job and verification failures are separated from provider/API regressions. 🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
🟢 Approval recommended
The change is documentation-only and low risk, with only a minor punctuation fix suggested in the updated emoji legend.
Pull request overview
Refines the internal .agents/skills/summarize-test-suite guidance to reduce false “code regression” (red) verdicts for recurring Atlas backend/verification failures, while keeping genuinely novel provider/API regressions classified as red for on-call visibility.
Changes:
- Tightens category 1 (code regression) classification so attribute/plan/
INVALID_ATTRIBUTEsymptoms are only red when they don’t match known-benign signatures or propagation-lag cases. - Adds category 3b (“Backend job / verify failures”) with explicit recurring signatures and guidance to report them under the existing API errors count line.
- Updates discipline rules and Slack output templates to reflect the new 3b sub-bucket and symptom-vs-cause classification.
File summaries
| File | Description |
|---|---|
| .agents/skills/summarize-test-suite/SKILL.md | Updates failure categorization rules and output templates to prevent recurring backend failures from being misclassified as code regressions. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
EspenAlbert
left a comment
There was a problem hiding this comment.
Thank you for improving this.
One thing. Would it be better to have all the different known test instabilities in a single place? This way it is easier to add remove and we don't need exceptions spread out?
Description
Refines the
summarize-test-suiteskill (.agents/skills/summarize-test-suite/SKILL.md) so nightly summaries stop mislabeling recurring backend failures as code regressions while still catching genuine provider and API regressions.Changes:
INVALID_ATTRIBUTEare red only when they do not match a known-benign 3b signature or a category 4 propagation-lag mismatch.FAILED, the acceptance-test sample-dataset load job reachingFAILED, and stale cluster/monitoring messages (Cannot validate cluster compatibility due to stale monitoring data,OPERATION_INVALID_SHARDS_NO_PRIMARY).API errorscount line, which the monthly summary parser already recognizes, so the monthly script is unchanged.Observed in the Sep 9 and Sep 10 nightly Test Suite runs, where LDAP verify, online archive / search index / collection restore sample-data seed, and advanced cluster stale-monitoring failures were misclassified as code regressions.
Link to any related issue(s):
Type of change:
Required Checklist:
Further comments