Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert csproj files to SDK style. #340

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Convert csproj files to SDK style. #340

merged 1 commit into from
Feb 9, 2021

Conversation

jpobst
Copy link
Member

@jpobst jpobst commented Feb 9, 2021 •
edited
Loading

Update Mono.Debug* csproj files to SDK style projects.

The unit tests in Xamarin.Android use these assemblies to ensure that changes do not break the ability to debug XA applications.

In order to target .NET 5/6 we need to build with dotnet build, which requires SDK style projects.

This PR avoids the API breakage in #288 by continuing to target net472 instead of updating to netstandard2.0.

@jpobst jpobst marked this pull request as ready for review February 9, 2021 20:52
@jpobst jpobst merged commit 8bf09ce into master Feb 9, 2021
@jpobst jpobst deleted the sdk-style branch February 9, 2021 21:47
@mrward
Copy link
Member

mrward commented Feb 10, 2021

This is causing compat check failures in VS Mac.

  Assembly MonoDevelop.Debugger.AD7 is referencing Mono.Debugging, Version=0.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f but found Mono.Debugging, Version=1.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f at Contents/Resources/lib/monodevelop/bin/Mono.Debugging.dll
  Assembly MonoDevelop.Debugger.Soft.IPhone is referencing Mono.Debugger.Soft, Version=0.0.0.0, Culture=neutral, PublicKeyToken=0738eb9f132ed756 but found Mono.Debugger.Soft, Version=1.0.0.0, Culture=neutral, PublicKeyToken=0738eb9f132ed756 at Contents/Resources/lib/monodevelop/AddIns/MonoDevelop.Debugger.Soft/Mono.Debugger.Soft.dll
  Assembly MonoDevelop.Debugger.Soft.IPhone is referencing Mono.Debugging, Version=0.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f but found Mono.Debugging, Version=1.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f at Contents/Resources/lib/monodevelop/bin/Mono.Debugging.dll
  Assembly MonoDevelop.Debugger.Soft.IPhone is referencing Mono.Debugging.Soft, Version=0.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f but found Mono.Debugging.Soft, Version=1.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f at Contents/Resources/lib/monodevelop/AddIns/MonoDevelop.Debugger.Soft/Mono.Debugging.Soft.dll
  Assembly MonoDevelop.Debugger.Soft.MonoDroid is referencing Mono.Debugging, Version=0.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f but found Mono.Debugging, Version=1.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f at Contents/Resources/lib/monodevelop/bin/Mono.Debugging.dll
  Assembly MonoDevelop.Debugger.Soft.MonoDroid is referencing Mono.Debugging.Soft, Version=0.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f but found Mono.Debugging.Soft, Version=1.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f at Contents/Resources/lib/monodevelop/AddIns/MonoDevelop.Debugger.Soft/Mono.Debugging.Soft.dll
  Assembly MonoDevelop.Debugger.Soft.MonoMac is referencing Mono.Debugger.Soft, Version=0.0.0.0, Culture=neutral, PublicKeyToken=0738eb9f132ed756 but found Mono.Debugger.Soft, Version=1.0.0.0, Culture=neutral, PublicKeyToken=0738eb9f132ed756 at Contents/Resources/lib/monodevelop/AddIns/MonoDevelop.Debugger.Soft/Mono.Debugger.Soft.dll
  Assembly MonoDevelop.Debugger.Soft.MonoMac is referencing Mono.Debugging, Version=0.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f but found Mono.Debugging, Version=1.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f at Contents/Resources/lib/monodevelop/bin/Mono.Debugging.dll
  Assembly MonoDevelop.Debugger.Soft.MonoMac is referencing Mono.Debugging.Soft, Version=0.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f but found Mono.Debugging.Soft, Version=1.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f at Contents/Resources/lib/monodevelop/AddIns/MonoDevelop.Debugger.Soft/Mono.Debugging.Soft.dll
  Assembly MonoDevelop.Unity is referencing Mono.Debugging, Version=0.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f but found Mono.Debugging, Version=1.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f at Contents/Resources/lib/monodevelop/bin/Mono.Debugging.dll
  Assembly Xamarin.Addins.Core is referencing Mono.Debugging, Version=0.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f but found Mono.Debugging, Version=1.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f at Contents/Resources/lib/monodevelop/bin/Mono.Debugging.dll
  Assembly Xamarin.HotReload.Bridge is referencing Mono.Debugger.Soft, Version=0.0.0.0, Culture=neutral, PublicKeyToken=0738eb9f132ed756 but found Mono.Debugger.Soft, Version=1.0.0.0, Culture=neutral, PublicKeyToken=0738eb9f132ed756 at Contents/Resources/lib/monodevelop/AddIns/MonoDevelop.Debugger.Soft/Mono.Debugger.Soft.dll
  Assembly Xamarin.HotReload.Bridge is referencing Mono.Debugging, Version=0.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f but found Mono.Debugging, Version=1.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f at Contents/Resources/lib/monodevelop/bin/Mono.Debugging.dll
  Assembly Xamarin.HotReload.Bridge is referencing Mono.Debugging.Soft, Version=0.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f but found Mono.Debugging.Soft, Version=1.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f at Contents/Resources/lib/monodevelop/AddIns/MonoDevelop.Debugger.Soft/Mono.Debugging.Soft.dll
  Assembly Xamarin.HotReload.Ide is referencing Mono.Debugging, Version=0.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f but found Mono.Debugging, Version=1.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f at Contents/Resources/lib/monodevelop/bin/Mono.Debugging.dll
  Assembly Xamarin.HotReload.Ide is referencing Mono.Debugging.Soft, Version=0.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f but found Mono.Debugging.Soft, Version=1.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f at Contents/Resources/lib/monodevelop/AddIns/MonoDevelop.Debugger.Soft/Mono.Debugging.Soft.dll
  Assembly Xamarin.HotReload.VSMac is referencing Mono.Debugging, Version=0.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f but found Mono.Debugging, Version=1.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f at Contents/Resources/lib/monodevelop/bin/Mono.Debugging.dll
  Assembly Xamarin.HotReload.VSMac is referencing Mono.Debugging.Soft, Version=0.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f but found Mono.Debugging.Soft, Version=1.0.0.0, Culture=neutral, PublicKeyToken=5e9ce85b0923c84f at Contents/Resources/lib/monodevelop/AddIns/MonoDevelop.Debugger.Soft/Mono.Debugging.Soft.dll

Sdks style projects seem to set the AssemblyVersion to 1.0.0.0 whilst classic projects set it to 0.0.0.0 by default.

@mrward
Copy link
Member

mrward commented Feb 10, 2021

Created another PR, which I will test with a VS Mac build now, with the assembly versions set to 0.0.0.0 - #341

mauroa pushed a commit to mauroa/debugger-libs that referenced this pull request Sep 21, 2023
@dependabot
Bump GitInfo from 2.1.2 to 2.3.0 (mono#340)
7310db5 
Bumps [GitInfo](https://github.com/devlooped/GitInfo) from 2.1.2 to 2.3.0.
- [Release notes](https://github.com/devlooped/GitInfo/releases)
- [Changelog](https://github.com/devlooped/GitInfo/blob/main/changelog.md)
- [Commits](devlooped/GitInfo@v2.1.2...v2.3.0)

---
updated-dependencies:
- dependency-name: GitInfo
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joj joj joj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpobst @mrward @joj