Adding Url property to UrlLinkFrame #365
Open
+182
−142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding Url and Description to UserUrlLinkFrame Fixing serialization format to conform to specification at https://id3lib.sourceforge.net/id3/id3v2.3.0.html#sec4.3
|
@dotnet-policy-service agree |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for URL link frames, including a new UserUrlLinkFrame with separate URL and description properties, and updates serialization to conform to the ID3v2.3.0 specification.
- Modified Tag.cs to handle UserUrlLinkFrame differently from standard URL link frames
- Refactored UrlLinkFrame to replace text-based properties with a dedicated Url property and updated parsing/rendering logic
- Added new tests for UrlLinkFrame and UserUrlLinkFrame to validate proper behavior
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/TaglibSharp/Id3v2/Tag.cs | Updates in SetTextFrame to differentiate between standard and user URL frames |
| src/TaglibSharp/Id3v2/Frames/UrlLinkFrame.cs | Refactored URL handling, deprecated Text property, and modified parsing/rendering |
| src/TaglibSharp.Tests/TaggingFormats/Id3V2Test.cs | Added tests for both UrlLinkFrame and UserUrlLinkFrame |
| if (isUserUrlLink) { | ||
| var userUrlLinkFrame = (UserUrlLinkFrame)urlLinkFrame; | ||
| userUrlLinkFrame.DescriptionEncoding = DefaultEncoding; | ||
| userUrlLinkFrame.Description = text[0]; |
There was a problem hiding this comment.
Accessing text[0] and text[1] directly without checking the length of the 'text' array may lead to an index out-of-range exception. Consider validating that the 'text' array has at least two elements before assignment.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #333
Adding Url and Description to UserUrlLinkFrame
Fixing serialization format to conform to specification at https://id3lib.sourceforge.net/id3/id3v2.3.0.html#sec4.3