Repository navigation
FIX: [2.x] choose target modal stacks backdrops and does not close after selecting a target - #64
Merged
Conversation
…ter selecting a target
jacquesbh
approved these changes
Jul 29, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Sylius 2.x admin “modal portal” behavior that causes the menu “choose target” browser modal to leave orphaned modals/backdrops behind (darkening the UI over time) and sometimes prevents the modal from closing after selecting a target.
Changes:
- Added a
monsieurbizSyliusMenuBrowserDestroyModal(locale)helper to dispose/remove previously created modals (even if portaled to<body>) and clean up global modal UI state. - Updated the modal loading flow to always destroy any prior modal before rendering/showing the next one, and to simplify the non-200 response path.
- Updated a doc comment to better describe selecting an item for a provider.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Member
|
Thank you @crydotsnake ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #63