Skip to content

refactor: update Show implementation for Char to use new syntax and improve output handling #2046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor: update Show implementation for Char to use new syntax and improve output handling #2046

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions builtin/show.mbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,15 +204,7 @@ pub impl[X : Show] Show for Array[X] with output(self, logger) {
}

///| Convert Char to String
pub impl Show for Char with to_string(self : Char) -> String {
char_to_string(self)
}

///| TODO: support attributes for impl
#intrinsic("%char.to_string")
fn char_to_string(char : Char) -> String {
[char]
}
pub impl Show for Char with to_string(self) = "%char.to_string"

///|
pub impl Show for Char with output(self, logger) {
Expand Down
Loading