Update tags. #1131
Merged
Update tags. #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kompotkot
reviewed
Oct 2, 2024
| @@ -1184,7 +1184,7 @@ def create_resource_for_user( | |||
| def chekc_user_resource_access( | |||
There was a problem hiding this comment.
chekc_user_resource_access -> check_user_resource_access
| @@ -109,12 +109,14 @@ async def add_subscription_handler( | |||
| user_token=token, | |||
| ) | |||
|
|
|||
| if not results: | |||
| if results is None: | |||
| raise MoonstreamHTTPException( | |||
| status_code=403, | |||
There was a problem hiding this comment.
Better to type 404, and error "Not found" even user do not have access to it
| @@ -309,6 +309,8 @@ | |||
| "user_id", | |||
| "address", | |||
| "blockchain", | |||
| "customer_id", | |||
There was a problem hiding this comment.
What about journal entities changes (at spire). We added here reserved tags, but not modified the source. Why just not to use required_fields https://spire.bugout.dev/journals/docs#tag/entities/operation/create_journal_entity__journal_id__entities_post
?
There was a problem hiding this comment.
Old one remain same. New one will have new tags
| @@ -624,7 +638,7 @@ async def update_subscriptions_handler( | |||
| f"{key}:{value}" | |||
| for tag in subscription_required_fields | |||
| for key, value in tag.items() | |||
| if key not in MOONSTREAM_ENTITIES_RESERVED_TAGS | |||
| if key not in MOONSTREAM_ENTITIES_RESERVED_TAGS and key != "instance_name" | |||
There was a problem hiding this comment.
Why do we need here check instance name, since instance_name already in reserved tags?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.