incoming/web: always trim fileID in cancel handler

moov-io · Apr 12, 2024 · e8a003d · e8a003d
1 parent e8f7b6d
commit e8a003d
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/internal/incoming/web/api_files.go b/internal/incoming/web/api_files.go
@@ -193,6 +193,9 @@ func (c *FilesController) CancelFileHandler(w http.ResponseWriter, r *http.Reque
 		return
 	}
 
+	// Remove .ach suffix if the request added it
+	fileID = strings.TrimSuffix(fileID, ".ach")
+
 	ctx, span := telemetry.StartSpan(r.Context(), "cancel-file-handler", trace.WithAttributes(
 		attribute.String("achgateway.shardKey", shardKey),
 		attribute.String("achgateway.fileID", fileID),
@@ -231,9 +234,6 @@ func (c *FilesController) CancelFileHandler(w http.ResponseWriter, r *http.Reque
 }
 
 func (c *FilesController) cancelFile(ctx context.Context, shardKey, fileID string, waiter chan models.FileCancellationResponse) error {
-	// Remove .ach suffix if the request added it
-	fileID = strings.TrimSuffix(fileID, ".ach")
-
 	c.cancellationLock.Lock()
 	c.activeCancellations[fileID] = waiter
 	c.cancellationLock.Unlock()