Skip to content

feat: Update PartyIdentification validation to accept EIN, TIN, and FIN codes for Party 30 and 34 #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arun-kushwaha04 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: Update PartyIdentification validation to accept EIN, TIN, and FIN codes for Party 30 and 34 #108

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14f8fe4
feat: Update PartyIdentification validation to accept EIN, TIN, and F…
arun-kushwaha04 Nov 10, 2025
f2e500a
Update pkg/suspicious_activity/activity.go
arun-kushwaha04 Nov 10, 2025
6254f37
Update pkg/suspicious_activity/activity.go
arun-kushwaha04 Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/suspicious_activity/activity.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ const (
PartyBranch = "46"
PartyITCTCC = "28"
PartyITCTIN = "4"
PartyITCEIN = "1"
PartyITCFIN = "2"
)

Expand Down Expand Up @@ -264,7 +265,7 @@ func (r PartyType) fieldInclusion() error {
if len(r.PartyIdentification) < 1 || len(r.PartyIdentification) > 3 {
return fincen.NewErrValueInvalid("PartyIdentification")
}
if !existed[PartyITCFIN] {
if !existed[PartyITCEIN] && !existed[PartyITCTIN] && !existed[PartyITCFIN] {
return fincen.NewErrValueInvalid("PartyIdentification")
}
case PartyContactOffice:
Expand All @@ -285,7 +286,7 @@ func (r PartyType) fieldInclusion() error {
if len(r.PartyIdentification) < 1 || len(r.PartyIdentification) > 3 {
return fincen.NewErrValueInvalid("PartyIdentification")
}
if !existed[PartyITCFIN] {
if !existed[PartyITCEIN] && !existed[PartyITCTIN] && !existed[PartyITCFIN] {
return fincen.NewErrValueInvalid("PartyIdentification")
}
case PartySubject:
Expand Down