Skip to content

Use a better way of getting the CARGO_TARGET_DIR #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kixelated merged 1 commit into from
Dec 18, 2025
Merged

Use a better way of getting the CARGO_TARGET_DIR #786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion rs/libmoq/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ authors = ["Luke Curley <[email protected]>", "Brian Medley <[email protected]>"
repository = "https://github.com/moq-dev/moq"
license = "MIT OR Apache-2.0"

version = "0.2.0"
version = "0.2.1"
edition = "2021"

keywords = ["quic", "http3", "webtransport", "media", "live"]
Expand Down
19 changes: 10 additions & 9 deletions rs/libmoq/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,14 @@ fn main() {
}

fn target_dir() -> PathBuf {
// Always use the workspace target directory (target/)
// regardless of whether --target is used or not.
// CARGO_MANIFEST_DIR is rs/libmoq/, so go up two levels to repo root
PathBuf::from(env::var("CARGO_MANIFEST_DIR").unwrap())
.parent()
.expect("Failed to get parent of CARGO_MANIFEST_DIR")
.parent()
.expect("Failed to get repo root")
.join("target")
// OUT_DIR is always set by Cargo to something like:
// target/{debug|release}/build/{crate}-{hash}/out
// Go up 4 levels to get to target/
PathBuf::from(env::var("OUT_DIR").unwrap())
.parent() // build/{crate}-{hash}
.and_then(|p| p.parent()) // build/
.and_then(|p| p.parent()) // {debug|release}/
.and_then(|p| p.parent()) // target/
.expect("Failed to get target directory from OUT_DIR")
.to_path_buf()
}
Loading