moq-native: Add websocket fallback option #808
Draft
+207
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only for convenience in developing with cross-repo deps.
We'll get a cleaner diff when we add another connection method to the struct in a future commit.
If desired, use Client::connect_with_fallback() to use a WebSocket-based transport when the QUIC connection fails. The logic mirrors the TypeScript implementation by affording the QUIC codepath a small (configurable) headstart.
kixelated
reviewed
Jan 2, 2026
| self.connect_quic(url).await | ||
| } | ||
|
|
||
| pub async fn connect_with_fallback(&self, url: Url) -> anyhow::Result<WebTransportSessionAny> { |
Collaborator
There was a problem hiding this comment.
I wonder if instead of WebTransportSessionAny, we could return an enum for Quinn or WebSocket. moq_lite is generic over both of these so it would be faster than doing an enum dispatch.
kixelated
reviewed
Jan 2, 2026
| env = "MOQ_CLIENT_WEBSOCKET_DELAY", | ||
| default_value = "200ms" | ||
| )] | ||
| #[serde(deserialize_with = "deserialize_humantime")] |
Collaborator
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on a new crate introduced by moq-dev/web-transport#138 .