Conversation
stackotter
force-pushed
the
stackotter/music_player
branch
from
c10bc7a to
7eea7fd
Compare
Contributor
|
Once you've merged in #392, do you suppose you'd be able to use that for persistence instead? Or is this persisting too much data for that to be appropriate? |
Collaborator
Author
|
I’ll have to look into it, but I feel like it’s probably too much data for AppStorage to be appropriate. But I’m not sure, the threshold might be different to SwiftUI due to your Codable support |
Contributor
|
If you are interested we could try Vein ^^ although that might be less than optimal due to version compatibility 🥲 I really need to expand it at some point. Might have to give up traits |
Contributor
|
@MiaKoring If you really wanted, you could write an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces MusicPlayerExample which is a basic MP3 player. Users can create playlists and load mp3/wav files off their file system. Everything gets persisted to disk. Audio playback is supported by swift-miniaudio.