Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French-translation #169

Merged
merged 22 commits into from
Feb 21, 2025
Merged

French-translation #169

merged 22 commits into from
Feb 21, 2025

Conversation

olivierbeau
Copy link
Contributor

Fixing some filtering and ordering when displaying exercises
Fixing language filtering
Adding a language tag to frontmatter (and graphql queries)

First batch of french translation

@olivierbeau olivierbeau added the Translation Translation support or new translation label Jan 15, 2025
Copy link
Member

@mimiflynn mimiflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that .gitignore file adjustment and we are good to go. This is huge!

@poojanagvekar
Copy link
Contributor

Attempting UI testing .....
Spined locally

  1. I am not sure if it's for me but the local run takes a while for every click it shows preparing to load which was not the case before
  2. The image is broken on this page and UI formatting is not inclined
Screenshot 2025-01-25 at 7 35 39 PM
  1. It says French selection, but it shows me English by default with the browser. if that is the case why do we need fr can we not just use the auto-translate feature?
Screenshot 2025-01-25 at 7 41 08 PM

@poojanagvekar
Copy link
Contributor

broken Images:
Screenshot 2025-01-25 at 7 50 08 PM

@mimiflynn
Copy link
Member

@poojanagvekar I'm seeing English in the French Makecode files. @olivierbeau did you check in all of your files?

Also, images are working on my local environment even after a full restart. Mind building again locally and seeing if the images are still broken? I can spin up a new clone if needed.

Thanks!

@poojanagvekar
Copy link
Contributor

@olivierbeau I think you need to check all file content once again many files still have English content, and many links index is broken example above. This PR needs through UI testing locally for now.

@mimiflynn images loaded fine for me this time seems codespaces issue last time

@olivierbeau
Copy link
Contributor Author

@poojanagvekar this is not a full translation yet, just the base of it.

However I'll try to get some of the curriculums translated fully, so that you can do it in french start to finish.

The goal here is to get started, not to do it all in one pass :p

mimiflynn and others added 2 commits February 3, 2025 12:02
Removing the robotic curriculum as we don't have the hardware now and can be deprioritized for translation
@olivierbeau
Copy link
Contributor Author

Please get a look to see if there is no more mixed french/english and everthing available is translated @poojanagvekar @mimiflynn

@mimiflynn mimiflynn merged commit 0b198b7 into main Feb 21, 2025
2 checks passed
@mimiflynn mimiflynn deleted the french-translation branch February 21, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Translation Translation support or new translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants