-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
French-translation #169
French-translation #169
Conversation
added a language tag to frontmatter data
… doing the job" This reverts commit f9d8ac116e41c23e0f2d899664a8d0ef075baeab.
remove language tag inserted for a test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just that .gitignore
file adjustment and we are good to go. This is huge!
This reverts commit 41d8e7c.
@poojanagvekar I'm seeing English in the French Makecode files. @olivierbeau did you check in all of your files? Also, images are working on my local environment even after a full restart. Mind building again locally and seeing if the images are still broken? I can spin up a new clone if needed. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exercises/fr-CA/circuitpython/ need to fix index, UI takes to absolute path like...
/exercises/en-US/circuitpython/robotics/
/exercises/en-US/imagicharm/level-1/
/exercises/en-US/imagicharm/level-2/
/exercises/en-US/imagicharm/level-3/
/exercises/en-US/makecode/intro/
/exercises/en-US/makecode/robotics/
/exercises/fr-CA/circuitpython/level-1/
/exercises/fr-CA/circuitpython/level-2/
/exercises/fr-CA/circuitpython/robotics/
/exercises/fr-CA/imagicharm/level-1/
/exercises/fr-CA/imagicharm/level-2/
/exercises/fr-CA/imagicharm/level-3/
/exercises/fr-CA/makecode/intro/
/exercises/fr-CA/makecode/robotics/
/exercises/en-US/circuitpython/level-1/L1-E1/
/exercises/en-US/circuitpython/level-1/L1-E2/
@olivierbeau I think you need to check all file content once again many files still have English content, and many links index is broken example above. This PR needs through UI testing locally for now. @mimiflynn images loaded fine for me this time seems codespaces issue last time |
@poojanagvekar this is not a full translation yet, just the base of it. However I'll try to get some of the curriculums translated fully, so that you can do it in french start to finish. The goal here is to get started, not to do it all in one pass :p |
Removing the robotic curriculum as we don't have the hardware now and can be deprioritized for translation
Please get a look to see if there is no more mixed french/english and everthing available is translated @poojanagvekar @mimiflynn |
Fixing some filtering and ordering when displaying exercises
Fixing language filtering
Adding a language tag to frontmatter (and graphql queries)
First batch of french translation