Add Prometheus metrics support #13
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
yvlasenko
pushed a commit
to yvlasenko/s3-sftp-proxy
that referenced
this pull request
Jan 15, 2020
yvlasenko
added a commit
to yvlasenko/s3-sftp-proxy
that referenced
this pull request
Jan 15, 2020
* address linter error #1 * address linter error #2 * address linter error #3 * address linter error #4 * address linter error #5 * address linter error #6 * address linter error #7 * address linter error #8 * address linter error #9 * address linter error moriyoshi#10 * address linter error moriyoshi#11 * address linter error moriyoshi#12 * address linter error moriyoshi#13 * address linter error moriyoshi#14 * address linter error moriyoshi#15 * address linter error moriyoshi#16 * address linter error moriyoshi#17 * Add linter action stage * Update path
alin-florea
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@moriyoshi would suggest adding Prometheus metrics support. The downside is that resulting binary is almost 50% larger.
This branch also includes #12, should be rebased if it get's merged.