Add empty default for cups::printers hiera lookup#54
Open
mattyindustries wants to merge 1 commit intomosen:masterfrom
Open
Add empty default for cups::printers hiera lookup#54mattyindustries wants to merge 1 commit intomosen:masterfrom
mattyindustries wants to merge 1 commit intomosen:masterfrom
Conversation
The Hiera variable cups::printers has been added to allow end users to define their printers in hiera and require no additional puppet manifest code than 'include cups'. However by not including a default option the puppet manifest will fail if the user does not specify cups::printer in Hiera. This change will add a blank hash to the hiera_hash call so that if it returns nothing then no error is logged and no printers created
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Hiera variable cups::printers has been added to allow end users to define their printers in hiera and require no additional puppet manifest code than 'include cups'.
However by not including a default option the puppet manifest will fail if the user does not specify cups::printer in Hiera.
This change will add a blank hash to the hiera_hash call so that if it returns nothing then no error is logged and no printers created