Channel.basic_publish does not adhere to it's return type.#183
Open
MaPePeR wants to merge 3 commits intomosquito:masterfrom
Open
Channel.basic_publish does not adhere to it's return type.#183MaPePeR wants to merge 3 commits intomosquito:masterfrom
MaPePeR wants to merge 3 commits intomosquito:masterfrom
Conversation
…ype`. `Channel.confirmations` contains the `Future`s used by `basic_publish`, so the `Future` needs to adhere to the return type of `basic_publish`. This reveals an error in `Channel._on_return_frame`, which resolves the `Future` to `DeliveredMessage`, which is not a `ConfirmationFrameType`
Owner
|
This not compatible for older python versions as you can see. |
Author
|
Latest commit should fix the incompatibility with old python versions. Sadly had to resort to |
This avoids the check for sys.version_info.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specify that
ConfirmationTypeFuturecontainsConfirmationFrameType.Channel.confirmationscontains theFutures used bybasic_publish, so theFutureneeds to adhere to the return type ofbasic_publish.Setting the type reveals an error in
Channel._on_return_frame, which resolves theFuturetoDeliveredMessage, which is not aConfirmationFrameType, thus breaking it's contract.Not sure how to proceed here, tbh., because fixing this can probably be considered a BC-break at this point?
The
DeliveredMessagethat is wrongly returned bybasic_publishcan be reproduced by trying to publish to thedefault_exchangewith arouting_keythat doesn't match any queue and havingon_return_raises=False(which for some reason is the default inaio-pika? 😳).#100 might be related to this.