Skip to content

Conversation

@michalismeng
Copy link

What's changing

Clear the persisted session state when the inputs of the podcast generation are changed or the "Generate Podcast" button is clicked. This fixes #137, where previously generated podcasts were concatenated into the script and audio file. Also when the inputs change (e.g., the chosen file for the podcast), it makes sense to reset the state and recalculate it as part of the page refresh.

Closes #137

How to test it

Steps to test the changes for #137:

  1. Generate a podcast (upload a file and click "Generate Podcast").
  2. Click "Generate Podcast" again to generate the podcast a second time.
  3. Download the podcast script text and audio files.
  4. Verify only the last podcast is in the downloaded files. The downloaded content should match the dialog snippets in the UI.

Other tests regarding clearing state:

  1. Upload a file.
  2. Remove the uploaded file by clicking the "x" button.
  3. Ensure all the sections below are removed (e.g., "Loading and Cleaning Data", "Podcast generation", etc..)
  1. Upload a file.
  2. Generate a podcast.
  3. Change one of the inputs (speaker configuration, raw/cleaned text, upload a different file, enter a URL, etc...)
  4. Ensure the generated podcast section is reset, the download buttons are removed.

Additional notes for reviewers

I already...

  • Tested the changes in a working environment to ensure they work as expected
  • Added some tests for any new functionality
  • Updated the documentation (both comments in code and under /docs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Downloaded text script contains all previously generated podcasts

1 participant